-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tag search to not require wildcards #481
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add a test for this scenario, so there wont be any regression in future, thanks.
Sorry, I'm not sure how test for this, since it was purely an issue with the SQL interaction and I can't see any other examples of a SQL test. |
here's a test for tag name lookup, so you can add it there: TagStudio/tagstudio/tests/test_library.py Lines 77 to 90 in af642a7
Looking on the test again, it would be better to use TagStudio/tagstudio/tests/test_library.py Lines 342 to 350 in af642a7
|
Added a test 👍 |
Mergeable once the Ruff error is addressed |
Previously, searching for tags required % wildcards to be added either side in order to search for a tag without an exact match, however this removes that requirement.