Change "show file in explorer" to be different depending on the OS #370

SupKittyMeow · 2024-08-23T01:00:11Z

Windows says explorer, Mac says Finder, and Linux just says filesystem (as I don't know what it is on Linux)

This reverts commit 0210b80.

This reverts commit dd7041c.

CyanVoxel

Adding to my Linux file manager comment, I would suggest putting the Linux case last in the if-else chain and instead have Windows as the middle case since both Windows and macOS have expected file explorer names, while for Linux + any other case we can use a generic catch-all term.

Also, are you able to use Ruff for linting or would you need some help with that?

tagstudio/src/qt/widgets/item_thumb.py

Co-authored-by: Travis Abendshien <[email protected]>

SupKittyMeow · 2024-08-23T03:20:39Z

Adding to my Linux file manager comment, I would suggest putting the Linux case last in the if-else chain and instead have Windows as the middle case since both Windows and macOS have expected file explorer names, while for Linux + any other case we can use a generic catch-all term.

Also, are you able to use Ruff for linting or would you need some help with that?

That should be fixed now. I haven't ever used Linux, but yeah I've heard that there's multiple file managers somewhere.

I've never actually heard of Ruff, so I probably need help on that, but I'll also look into it.

CyanVoxel · 2024-08-24T07:17:30Z

In addition to the Ruff formatting it looks like MyPy is failing due to open_explorer_action being defined inside of the if-else blocks and the app run test is failing due to a mismatch between open_file_action and open_explorer_action

SupKittyMeow · 2024-08-25T02:20:25Z

In addition to the Ruff formatting it looks like MyPy is failing due to open_explorer_action being defined inside of the if-else blocks and the app run test is failing due to a mismatch between open_file_action and open_explorer_action

Should be fixed now.

CyanVoxel · 2024-08-25T02:48:41Z

af4c0d1 is now trying to do a lot of additional things

SupKittyMeow · 2024-08-25T04:58:29Z

af4c0d1 is now trying to do a lot of additional things

oh i did that because of all of the Ruff warnings

CyanVoxel · 2024-08-25T05:13:57Z

oh i did that because of all of the Ruff warnings

Ruff provides additional lint suggestions in addition to what it's configured to format when run, either locally or though the workflow check. Using ruff format as described in the CONTRIBUTING.md would've fixed the issues the check was failing on. Now there are several additional changes that are out of the scope of this PR - I would just revert your changes made in af4c0d1 (please use more descriptive commit names than "thing" in the future) and run ruff format while leaving the other lint suggestions alone.

SupKittyMeow · 2024-08-25T05:28:51Z

oh i did that because of all of the Ruff warnings

Ruff provides additional lint suggestions in addition to what it's configured to format when run, either locally or though the workflow check. Using ruff format as described in the CONTRIBUTING.md would've fixed the issues the check was failing on. Now there are several additional changes that are out of the scope of this PR - I would just revert your changes made in af4c0d1 (please use more descriptive commit names than "thing" in the future) and run ruff format while leaving the other lint suggestions alone.

Oh ok will do rn

This reverts commit af4c0d1.

SupKittyMeow · 2024-08-25T05:40:25Z

Should be good now.

CyanVoxel · 2024-08-25T05:49:15Z

I'll take a look at the checks failing, one moment

… just normal open_explorer_action

SupKittyMeow · 2024-08-25T05:52:18Z

I forgot about something but now it should work.

CyanVoxel

Seems to be all good now! Thank you for working on this. I'll mark this as mergeable, but I'll still need to determine if this is better suited for the Alpha-v9.4 or post-#332 main branches. Nothing you need to worry about though - if I need to rebase I'll take care of that before pulling.

* Update item_thumb.py * Update preview_panel.py * Update video_player.py * made it so preview_panel.py uses self.open_explorer_action instead of just normal open_explorer_action

Ports the following thumbnail and related PRs from the `Alpha-v9.4` branch to `main` (v9.5+): - (#273) Blender thumbnail support - (#307) Add font thumbnail preview support - (#331) refactor: move type constants to new media classes - (#390) feat(ui): expanded thumbnail and preview features - (#370) ui: "open in explorer" action follows os name - (#373) feat(ui): preview support for source engine files - (#274) Refactor video_player.py (Fix #270) - (#430) feat(ui): show file creation/modified dates + restyle path label - (#471) fix(ui): use default audio icon if ffmpeg is absent - (#472) fix(ui): use birthtime for creation time on mac & win Co-Authored-By: Ethnogeny <[email protected]> Co-Authored-By: Theasacraft <[email protected]> Co-Authored-By: SupKittyMeow <[email protected]> Co-Authored-By: EJ Stinson <[email protected]> Co-Authored-By: Sean Krueger <[email protected]>

* feat: port v9.4 thumbnail + related feats to v9.5 Ports the following thumbnail and related PRs from the `Alpha-v9.4` branch to `main` (v9.5+): - (#273) Blender thumbnail support - (#307) Add font thumbnail preview support - (#331) refactor: move type constants to new media classes - (#390) feat(ui): expanded thumbnail and preview features - (#370) ui: "open in explorer" action follows os name - (#373) feat(ui): preview support for source engine files - (#274) Refactor video_player.py (Fix #270) - (#430) feat(ui): show file creation/modified dates + restyle path label - (#471) fix(ui): use default audio icon if ffmpeg is absent - (#472) fix(ui): use birthtime for creation time on mac & win Co-Authored-By: Ethnogeny <[email protected]> Co-Authored-By: Theasacraft <[email protected]> Co-Authored-By: SupKittyMeow <[email protected]> Co-Authored-By: EJ Stinson <[email protected]> Co-Authored-By: Sean Krueger <[email protected]> * remove vscode exceptions from `.gitignore` * delete .vscode directory * style: format for `ruff check` * fix(tests): update `test_update_widgets_not_selected` test * remove Send2Trash dependency * refactor: use dataclass for MediaCateogry * refactor: use enums for UI colors * docs: add file docstring for silent_Popen * refactor: replace logger with structlog * use early return inside `ResourceManager.get()` * add `is_ext_in_category()` method to `MediaCategory` Add method to check if an extension is a member of a given MediaCategory. * style: fix docstring style, missing type hints, rename `afm` * fix: use structlog vars in logging * refactor: move platform-dependent strings to PlatformStrings * refactor: move `parents[2]` path to variable * fix: undo logger regressions --------- Co-authored-by: Ethnogeny <[email protected]> Co-authored-by: Theasacraft <[email protected]> Co-authored-by: SupKittyMeow <[email protected]> Co-authored-by: EJ Stinson <[email protected]> Co-authored-by: Sean Krueger <[email protected]>

SupKittyMeow and others added 8 commits August 21, 2024 15:25

Update video_player.py

723e070

Update preview_panel.py

40b7ce1

Update constants.py

dd7041c

Update ts_qt.py

0210b80

Update item_thumb.py

0f2f3c7

update "open file in explorer" to "open file in filesystem" for Linux

666ad4a

Revert "Update ts_qt.py"

0ed41b3

This reverts commit 0210b80.

Revert "Update constants.py"

b571197

This reverts commit dd7041c.

CyanVoxel added Type: UI/UX User interface and/or user experience Status: Review Needed A review of this is needed labels Aug 23, 2024

CyanVoxel requested changes Aug 23, 2024

View reviewed changes

tagstudio/src/qt/widgets/item_thumb.py Outdated Show resolved Hide resolved

tagstudio/src/qt/widgets/item_thumb.py Outdated Show resolved Hide resolved

tagstudio/src/qt/widgets/item_thumb.py Outdated Show resolved Hide resolved

SupKittyMeow and others added 6 commits August 22, 2024 20:12

Update tagstudio/src/qt/widgets/item_thumb.py

920910f

Co-authored-by: Travis Abendshien <[email protected]>

Update tagstudio/src/qt/widgets/item_thumb.py

894b2a6

Co-authored-by: Travis Abendshien <[email protected]>

Update tagstudio/src/qt/widgets/item_thumb.py

ee7f4f7

Co-authored-by: Travis Abendshien <[email protected]>

Update item_thumb.py

a8d020f

Update preview_panel.py

9451bdd

Update video_player.py

7017e2f

CyanVoxel added Status: Changes Requested Changes are quested to this Priority: Low Doesn't require immediate attention and removed Status: Review Needed A review of this is needed labels Aug 24, 2024

SupKittyMeow and others added 4 commits August 24, 2024 19:05

Update item_thumb.py

b1c863e

Update preview_panel.py

7d67804

Update video_player.py

faef8c6

thing

af4c0d1

SupKittyMeow requested a review from CyanVoxel August 25, 2024 02:26

SupKittyMeow and others added 2 commits August 24, 2024 22:35

Revert "thing"

e460398

This reverts commit af4c0d1.

Format using Ruff

df8e8ee

made it so preview_panel.py uses self.open_explorer_action instead of…

dd4816d

… just normal open_explorer_action

CyanVoxel approved these changes Aug 25, 2024

View reviewed changes

CyanVoxel added Status: Mergeable The code is ready to be merged System: Windows For Microsoft Windows System: Linux For Linux/BSD distributions System: macOS For the macOS operating system and removed Status: Changes Requested Changes are quested to this labels Aug 25, 2024

CyanVoxel changed the base branch from main to Alpha-v9.4 August 28, 2024 04:59

CyanVoxel merged commit dcb8ded into TagStudioDev:Alpha-v9.4 Aug 31, 2024
4 checks passed

CyanVoxel mentioned this pull request Sep 22, 2024

feat: port thumbnail (#390) and related features to v9.5 #522

Merged

CyanVoxel removed the Status: Mergeable The code is ready to be merged label Nov 8, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change "show file in explorer" to be different depending on the OS #370

Change "show file in explorer" to be different depending on the OS #370

SupKittyMeow commented Aug 23, 2024

CyanVoxel left a comment

SupKittyMeow commented Aug 23, 2024

CyanVoxel commented Aug 24, 2024

SupKittyMeow commented Aug 25, 2024

CyanVoxel commented Aug 25, 2024

SupKittyMeow commented Aug 25, 2024

CyanVoxel commented Aug 25, 2024

SupKittyMeow commented Aug 25, 2024

SupKittyMeow commented Aug 25, 2024

CyanVoxel commented Aug 25, 2024

SupKittyMeow commented Aug 25, 2024

CyanVoxel left a comment

Change "show file in explorer" to be different depending on the OS #370

Change "show file in explorer" to be different depending on the OS #370

Conversation

SupKittyMeow commented Aug 23, 2024

CyanVoxel left a comment

Choose a reason for hiding this comment

SupKittyMeow commented Aug 23, 2024

CyanVoxel commented Aug 24, 2024

SupKittyMeow commented Aug 25, 2024

CyanVoxel commented Aug 25, 2024

SupKittyMeow commented Aug 25, 2024

CyanVoxel commented Aug 25, 2024

SupKittyMeow commented Aug 25, 2024

SupKittyMeow commented Aug 25, 2024

CyanVoxel commented Aug 25, 2024

SupKittyMeow commented Aug 25, 2024

CyanVoxel left a comment

Choose a reason for hiding this comment