fix: backslashes in f-string error on file drop dupe widget #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor excessively long f-string into separate variables
CyanVoxel
added
Type: Bug
CyanVoxel
reviewed
Jun 14, 2024
CyanVoxel
reviewed
Jun 14, 2024
| @@ -167,10 +167,11 @@ def duplicates_choice(self) -> int: | |||
| dupes_to_show = self.duplicate_files | |||
| if len(self.duplicate_files) > display_limit: | |||
| dupes_to_show = dupes_to_show[0:display_limit] | |||
|
|
|||
| dupes_str = '\n '.join(map(lambda path: str(path),dupes_to_show)) | |||
| dupes_more = f"\nand {len(self.duplicate_files)-display_limit} more " if len(self.duplicate_files) > display_limit else '\n' | |||
There was a problem hiding this comment.
But now there's a backslash inside of the f-string again, causing the issue in #289 😅
There was a problem hiding this comment.
That's a backslash inside the template, not the expression. Python was upset about backslashes being between the { } curly brackets. It seems to be running for me with these changes on 3.11.2
There was a problem hiding this comment.
Ah interesting, in that case if it works then I've got no issue with it
|
I can do the Ruff format, everything else looks good! |
3 tasks
CarterPillow
pushed a commit
to CarterPillow/TagStudio
that referenced
this pull request
Sep 7, 2024
…oDev#289) * fix: python complaining about backslashes inside f-string expressions refactor excessively long f-string into separate variables * fix: missing f on f-string * Format with Ruff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor excessively long f-string into separate variables to resolve issue
Fixes #288