Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed bug during lowering of zkML MatMul #26

Merged
merged 1 commit into from
Jan 11, 2024
Merged

fix: fixed bug during lowering of zkML MatMul #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libs/onnx-mlir
Open in desktop
Submodule onnx-mlir updated 1 files
+1 −4 src/Conversion/ONNXToKrnl/Math/MatMul.cpp
1 change: 1 addition & 0 deletions mlir-assigner/tests/Ops/Onnx/MatMul/MatMulNanoGPT.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
[{"memref": {"data": [0.0067901611328125, 0.0448760986328125, 0.1385040283203125, 0.67315673828125, 0.3114166259765625, 0.773101806640625, 0.029327392578125, 0.6287384033203125, 0.3452301025390625, 0.6697998046875, 0.43682861328125, 0.1864013671875, 0.758209228515625, 0.732177734375, 0.661529541015625, 0.2568206787109375, 0.0154876708984375, 0.5805206298828125, 0.5240631103515625, 0.289947509765625, 0.892547607421875, 0.6796112060546875, 0.31402587890625, 0.0582275390625, 0.2615966796875, 0.70526123046875, 0.6292877197265625, 0.837677001953125, 0.896209716796875, 0.8044891357421875, 0.6453399658203125, 0.0125274658203125, 0.865142822265625, 0.711761474609375, 0.2068634033203125, 0.9350433349609375, 0.987579345703125, 0.0557708740234375, 0.57110595703125, 0.0711212158203125, 0.07452392578125, 0.2938079833984375, 0.6302642822265625, 0.6785888671875, 0.0648193359375, 0.9690399169921875, 0.4239501953125, 0.4016571044921875, 0.3271026611328125, 0.56341552734375, 0.032379150390625, 0.96221923828125, 0.293182373046875, 0.5765838623046875, 0.461334228515625, 0.3267059326171875, 0.6459197998046875, 0.1910400390625, 0.67718505859375, 0.413055419921875, 0.5491790771484375, 0.0426025390625, 0.04345703125, 0.2328948974609375], "dims": [1, 2, 8, 4], "type": "f32"}}, {"memref": {"data": [0.82598876953125, 0.42034912109375, 0.0013580322265625, 0.9781494140625, 0.2749481201171875, 0.7566070556640625, 0.975128173828125, 0.7003326416015625, 0.4239044189453125, 0.2353973388671875, 0.34735107421875, 0.1881866455078125, 0.8909454345703125, 0.4473876953125, 0.372314453125, 0.1283111572265625, 0.69842529296875, 0.338104248046875, 0.0814971923828125, 0.7575225830078125, 0.890838623046875, 0.701385498046875, 0.5887298583984375, 0.35870361328125, 0.2598114013671875, 0.6739349365234375, 0.21380615234375, 0.2421875, 0.0974884033203125, 0.23504638671875, 0.5143890380859375, 0.5594940185546875, 0.464752197265625, 0.30023193359375, 0.0233306884765625, 0.550872802734375, 0.2153472900390625, 0.53955078125, 0.8239593505859375, 0.8917694091796875, 0.970733642578125, 0.5721282958984375, 0.79327392578125, 0.864013671875, 0.5154266357421875, 0.3584442138671875, 0.7467193603515625, 0.379364013671875, 0.1176605224609375, 0.6263885498046875, 0.755889892578125, 0.7117156982421875, 0.4590301513671875, 0.8849945068359375, 0.60113525390625, 0.24090576171875, 0.000274658203125, 0.5095062255859375, 0.2917022705078125, 0.69781494140625, 0.5694580078125, 0.251312255859375, 0.8696441650390625, 0.9749908447265625], "dims": [1, 2, 4, 8], "type": "f32"}}]
22 changes: 22 additions & 0 deletions mlir-assigner/tests/Ops/Onnx/MatMul/MatMulNanoGPT.onnx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
 :�

in_a
in_bout_a"MatMulMatMulNanoGPTZ
in_a




Z
in_b




b
out_a




B
Expand Down
3 changes: 3 additions & 0 deletions mlir-assigner/tests/Ops/Onnx/MatMul/MatMulNanoGPT.res
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Result:
memref<1x2x8x8xf32>[0.2962602972984314, 0.5139105916023254, 0.17080973088741302, 0.2830369472503662, 0.23085880279541016, 0.2805822789669037, 0.45113521814346313, 0.4368225336074829, 0.7687843441963196, 0.7465342879295349, 0.4057788848876953, 0.624588131904602, 0.8618355989456177, 0.7498487234115601, 0.9321901798248291, 0.6795880198478699, 0.9226086139678955, 0.5761022567749023, 0.3085785508155823, 0.839785635471344, 1.0989912748336792, 0.9110620021820068, 0.9390766024589539, 0.5887011289596558, 1.4653995037078857, 0.8878116607666016, 0.364175021648407, 1.442750334739685, 1.475151777267456, 1.4255857467651367, 1.5335193872451782, 1.0059279203414917, 0.7002285122871399, 0.5157569646835327, 0.3063677251338959, 0.5916067957878113, 1.0165927410125732, 0.7071572542190552, 0.6889161467552185, 0.435541033744812, 1.25977623462677, 0.6805753707885742, 0.2753174304962158, 1.2529222965240479, 1.1363236904144287, 1.213296890258789, 1.3382054567337036, 0.8575021028518677, 1.1721878051757812, 1.0532832145690918, 0.47571420669555664, 1.0681759119033813, 1.3425323963165283, 1.1517173051834106, 1.3190416097640991, 0.9681006669998169, 1.5352622270584106, 0.7927305102348328, 0.33592909574508667, 1.5199147462844849, 1.539282202720642, 1.493573784828186, 1.5598173141479492, 0.9693646430969238, 1.1176042556762695, 1.2729496955871582, 1.0139265060424805, 1.891270399093628, 1.180591344833374, 1.1399760246276855, 2.1818366050720215, 2.0030179023742676, 0.580334484577179, 0.7223818898200989, 0.5197219252586365, 1.0483119487762451, 0.5440737009048462, 1.076139211654663, 1.2605324983596802, 1.1087757349014282, 0.3941880464553833, 0.9310058951377869, 0.9091652035713196, 1.217005729675293, 0.8432231545448303, 0.873841404914856, 1.249801754951477, 0.9913705587387085, 1.0207970142364502, 1.044080376625061, 1.2078503370285034, 1.4549853801727295, 0.936760425567627, 0.8584550023078918, 1.3811595439910889, 0.9191668033599854, 0.7030220627784729, 0.93109130859375, 0.7597309947013855, 1.3614864349365234, 0.9236465692520142, 0.6489143967628479, 1.546485185623169, 1.451395034790039, 0.7503370642662048, 0.8733358383178711, 0.9082477688789368, 1.2160016298294067, 0.7581343054771423, 0.8552433848381042, 1.2335588932037354, 0.9098596572875977, 0.5654330253601074, 0.9378604888916016, 0.7989833950996399, 1.291080355644226, 0.7836302518844604, 1.120094656944275, 1.4411559104919434, 1.214348316192627, 0.3017650544643402, 0.33513760566711426, 0.14739291369915009, 0.532783567905426, 0.2927946448326111, 0.40856921672821045, 0.7129725813865662, 0.7434423565864563]
256