Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Locks after starting to intercept requests when there are no urls to block added #4

Closed
drptbl opened this issue May 20, 2018 · 1 comment
Closed

Locks after starting to intercept requests when there are no urls to block added #4

drptbl opened this issue May 20, 2018 · 1 comment

Comments

@drptbl
Copy link
Contributor

drptbl commented May 20, 2018

It fails to continue with requests and locks after starting to intercept requests when there are no urls to block added.
await interceptedUrl.continue(); is missing in:
https://github.com/Tabueeee/puppeteer-request-spy/blob/master/src/RequestInterceptor.ts#L119
@drptbl
Copy link
Contributor Author

drptbl commented May 20, 2018

Fixed with #5

@drptbl drptbl closed this as completed May 20, 2018
Tabueeee added a commit that referenced this issue May 21, 2018
@Tabueeee
removed conditional acceptUrl and added regression tests for issue #4
ea22821
Tabueeee added a commit that referenced this issue May 21, 2018
@Tabueeee
Merge pull request #6 from Tabueeee/v-1.1.2
4e5fa1a 
removed conditional acceptUrl and added regression tests for issue #4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@drptbl