Allow zero values for integer feedback scales. #2542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teymour-aldridge
force-pushed
the
validate
branch
from
9533f59 to
7a23007
Compare
tienne-B
reviewed
Nov 30, 2024
| if not self.cleaned_data.get('min_value') or not self.cleaned_data.get('max_value'): | ||
| raise forms.ValidationError(_("Integer scales must have a minimum and maximum")) | ||
| if self.cleaned_data.get('min_value') is None: | ||
| raise forms.ValidationError(_("Error: min_value must be specified for an integer scale.")) |
There was a problem hiding this comment.
If you want to split the messages for the field, you could use Form.add_error() so that the error shows for the specific field (and could simplify the message so that specifying the field isn't needed, like "A value is required when using an integer scale")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2541