feat(vscode): adding clickble symbol render in chat panel #3420
+320
−71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wsxiaoys
reviewed
Nov 17, 2024
wsxiaoys
reviewed
Nov 17, 2024
wsxiaoys
reviewed
Nov 17, 2024
wsxiaoys
changed the title
wsxiaoys
reviewed
Nov 18, 2024
|
Need handle cases that certain backend doesn't support such feature (e.g IntelliJ) |
Sma1lboy
force-pushed
the
feat-adding-clickble-keywords-chat-panel
branch
from
ddcbe91 to
c3d0709
Compare
The code changes in `ChatPage` component add support for the `onNavigateSymbol` and `onHoverSymbol` capabilities. These capabilities are checked and set using the `hasCapability` method of the server. The `onNavigateSymbol` and `onHoverSymbol` methods are conditionally used based on the support for these capabilities. This change enhances the functionality of the ChatPage component in the Tabby UI.
wsxiaoys
reviewed
Dec 1, 2024
wsxiaoys
reviewed
Dec 1, 2024
The ClientApi interface has been updated to make the onNavigateSymbol method optional. This change allows for better flexibility in implementing the interface, as the onNavigateSymbol method is now conditionally used based on the support for the capability. This update enhances the usability of the ClientApi interface in the Tabby UI.
The code changes in `ChatPage` component add support for the `onHoverSymbol` capability. This capability is checked and set using the `hasCapability` method of the server. The `onHoverSymbol` method is conditionally used based on the support for this capability. This change enhances the functionality of the ChatPage component in the Tabby UI.
Sma1lboy
force-pushed
the
feat-adding-clickble-keywords-chat-panel
branch
from
ac937a2 to
b45e256
Compare
…ure for improved clarity
…ookup logic for improved clarity and maintainability
…gic for consistency across components
Sma1lboy
force-pushed
the
feat-adding-clickble-keywords-chat-panel
branch
from
dbb0963 to
9be446b
Compare
wsxiaoys
changed the title
wsxiaoys
added a commit
that referenced
this pull request
Dec 9, 2024
* feat: add onRenderLsp event handler for rendering language server protocol * feat: Add onRenderLsp event handler for rendering language server protocol * chore(vscode): update targetFile path to use workspace relative path * refactor: Update code to use KeywordInfo type for onRenderLsp event handler * feat: add onNavigateSymbol method to ClientApi interface * feat: add onNavigateSymbol method to ClientApi interface * feat: add onNavigateSymbol method to ClientApi interface * feat: add onHoverSymbol method to ClientApi interface * feat: add onHoverSymbol and findSymbolInfo methods to WebviewHelper * feat: add onHoverSymbol and findSymbolInfo methods to WebviewHelper * fix: update onNavigateSymbol parameter name in ClientApi interface * fix: update onNavigateSymbol parameter name in ClientApi interface * feat: Add support for onNavigateSymbol and onHoverSymbol in ChatPage The code changes in `ChatPage` component add support for the `onNavigateSymbol` and `onHoverSymbol` capabilities. These capabilities are checked and set using the `hasCapability` method of the server. The `onNavigateSymbol` and `onHoverSymbol` methods are conditionally used based on the support for these capabilities. This change enhances the functionality of the ChatPage component in the Tabby UI. * chore: remove unused type * feat: Update ClientApi interface to make onNavigateSymbol optional The ClientApi interface has been updated to make the onNavigateSymbol method optional. This change allows for better flexibility in implementing the interface, as the onNavigateSymbol method is now conditionally used based on the support for the capability. This update enhances the usability of the ClientApi interface in the Tabby UI. * feat: Add support for onHoverSymbol in ChatPage The code changes in `ChatPage` component add support for the `onHoverSymbol` capability. This capability is checked and set using the `hasCapability` method of the server. The `onHoverSymbol` method is conditionally used based on the support for this capability. This change enhances the functionality of the ChatPage component in the Tabby UI. * [autofix.ci] apply automated fixes * feat: Add activeSelection prop to MessageMarkdown and update imports * feat: Rename parameter in onNavigateSymbol to hintFilepaths for clarity * feat: Implement CodeElement component for rendering code in Markdown * refactor: Remove onNavigateToContext prop from MessageMarkdown and related components for simplification * feat: Rename onNavigateSymbol to onLookupSymbol and update its signature for improved clarity * feat: Rename onNavigateSymbol to onLookupSymbol and refactor symbol lookup logic for improved clarity and maintainability * feat: Rename onNavigateSymbol to onLookupSymbol and update related logic for consistency across components * [autofix.ci] apply automated fixes * update: render symbol * Update icons.tsx * [autofix.ci] apply automated fixes --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: liangfung <[email protected]> Co-authored-by: Meng Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature
onLookupSymbolwith rendered inline blocks.navigateis not exposed.Demo
Screen.Recording.2024-12-05.at.15.59.48.mov
Screen.Recording.2024-11-30.at.06.37.15.mov