Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[!!!][TASK] Add configuration error note for single view plugins #94

Conversation

benjaminkott
Copy link
Member

@benjaminkott benjaminkott commented Aug 6, 2019

To prevent the usage of plugins that should only be
used on post views we are now adding additional
checks for those. If no post could be resolved - also
means if the plugin is used on pages that do not match
the Constants::DOKTYPE_BLOG_POST - the plugins will
now return a new message to make the miss usage visible.

A possible configuration error was detected.
No matching post could be obtained. Make sure that this plugin is only used on a post.

The following plugins will now show this message if no
post could be obtained:

  • Authors
  • Footer
  • Header
  • Metadata
  • RelatedPosts

Templates added:

  • Layouts/Post.html

Templates changed:

  • Templates/Comment/Comments.html
  • Templates/Comment/Form.html
  • Templates/Post/Authors.html
  • Templates/Post/Footer.html
  • Templates/Post/Header.html
  • Templates/Post/Metadata.html
  • Templates/Post/RelatedPosts.html

Releases: master

@benjaminkott benjaminkott force-pushed the task/add-configuration-error-note-for-singleview-plugins branch 2 times, most recently from 32d145d to ca01054 Compare August 7, 2019 20:41
@benjaminkott benjaminkott merged commit 780f018 into master Aug 7, 2019
@benjaminkott benjaminkott deleted the task/add-configuration-error-note-for-singleview-plugins branch August 7, 2019 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant