[!!!][TASK] Use TYPO3 Form Framework for comment form #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaminkott
changed the title
benjaminkott
force-pushed
the
task/use-formframework-forcomments
branch
2 times, most recently
from
185aaa5 to
4ddd140
Compare
The required form markup can vary a lot depending on the frontend implementation of the instance. To ease the blog integration in all kinds of frontends we decided to make use of the form framework of TYPO3. By using the form framework the blog will automaticly respect the already configured forms of the typo3 instance. This will remove the nesessity to provide custom form tempates for the comment form of the blog extension. This will also mean, thats its no longer possible to adjust the comment form directly, since this is now generated through the form framework API. During the mgration it was noticed that the google captcha implementation is currently only compatible with v2, this was added to the label for now to avoid configuration confusions while generating API Keys at google. Adjusted Tempaltes: * Templates/Comment/Form.html New Templates: * Partials/Comments/Form/Closed.html * Partials/Comments/Form/Disqus.html * Partials/Comments/Form/Local.html * Partials/Form/GoogleCaptcha.html Release: master
benjaminkott
force-pushed
the
task/use-formframework-forcomments
branch
from
4ddd140 to
b5ace4b
Compare
benjaminkott
changed the title
benjaminkott
commented
May 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The required form markup can vary a lot depending on the
frontend implementation of the instance. To ease the
blog integration in all kinds of frontends we decided to
make use of the form framework of TYPO3.
By using the form framework the blog will automatically
respect the already configured forms of the typo3 instance.
This will remove the necessity to provide custom form
templates for the comment form of the blog extension.
This will also mean, that's no longer possible to adjust
the comment form directly, since this is now generated
through the form framework API.
During the migration, it was noticed that the google captcha
implementation is currently only compatible with v2, this
was added to the label for now to avoid configuration
confusions while generating API Keys at google.
Adjusted Tempaltes:
New Templates:
Release: master