Skip to content

Commit

Permalink
[BUGFIX] Cast pageUid in RedirectFinisher to string (#173)
Browse files Browse the repository at this point in the history
Due to an undiscovered breaking change, redirects in the RedirectFinisher
don't work anymore if the pageUid is an integer. This change casts the
pageUid to a string to workaround this new behavior.

See https://review.typo3.org/c/Packages/TYPO3.CMS/+/65467 as well.
  • Loading branch information
andreaskienast authored Nov 27, 2020
1 parent 2ed0cf9 commit f9d3c1a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Classes/Domain/Factory/CommentFormFactory.php
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ public function build(array $configuration, string $prototypeName = null): FormD
$form->addFinisher($commentFinisher);

$redirectFinisher = $objectManager->get(RedirectFinisher::class);
$redirectFinisher->setOption('pageUid', $this->getTypoScriptFrontendController()->id);
$redirectFinisher->setOption('pageUid', (string)$this->getTypoScriptFrontendController()->id);
$form->addFinisher($redirectFinisher);

$this->triggerFormBuildingFinished($form);
Expand Down

0 comments on commit f9d3c1a

Please sign in to comment.