[TASK] Resolve v12 phpstan errors

Only the `findAll()` QueryResultInterface return type is kept,
as we do not return an array here.

Build/phpstan-baseline.neon

@@ -1,36 +1,6 @@
 parameters:
 	ignoreErrors:
 		-
-			message: "#^Call to method addHeaderContent\\(\\) on an unknown class TYPO3\\\\CMS\\\\Backend\\\\Controller\\\\Event\\\\ModifyPageLayoutContentEvent\\.$#"
+			message: "#^Return type \\(TYPO3\\\\CMS\\\\Extbase\\\\Persistence\\\\QueryResultInterface\\) of method T3G\\\\AgencyPack\\\\Blog\\\\Domain\\\\Repository\\\\PostRepository\\:\\:findAll\\(\\) should be covariant with return type \\(iterable\\<object\\>\\) of method TYPO3\\\\CMS\\\\Extbase\\\\Persistence\\\\RepositoryInterface\\<object\\>\\:\\:findAll\\(\\)$#"
 			count: 1
-			path: ../Classes/Listener/ModifyPageLayoutContent.php
-
-		-
-			message: "#^Call to method getRequest\\(\\) on an unknown class TYPO3\\\\CMS\\\\Backend\\\\Controller\\\\Event\\\\ModifyPageLayoutContentEvent\\.$#"
-			count: 1
-			path: ../Classes/Listener/ModifyPageLayoutContent.php
-
-		-
-			message: "#^Method T3G\\\\AgencyPack\\\\Blog\\\\Listener\\\\ModifyPageLayoutContent\\:\\:__invoke\\(\\) has no return type specified\\.$#"
-			count: 1
-			path: ../Classes/Listener/ModifyPageLayoutContent.php
-
-		-
-			message: "#^Parameter \\$event of method T3G\\\\AgencyPack\\\\Blog\\\\Listener\\\\ModifyPageLayoutContent\\:\\:__invoke\\(\\) has invalid type TYPO3\\\\CMS\\\\Backend\\\\Controller\\\\Event\\\\ModifyPageLayoutContentEvent\\.$#"
-			count: 1
-			path: ../Classes/Listener/ModifyPageLayoutContent.php
-
-		-
-			message: "#^Call to method addContentAbove\\(\\) on an unknown class TYPO3\\\\CMS\\\\Backend\\\\Controller\\\\Event\\\\RenderAdditionalContentToRecordListEvent\\.$#"
-			count: 1
-			path: ../Classes/Listener/RenderAdditionalContentToRecordList.php
-
-		-
-			message: "#^Call to method getRequest\\(\\) on an unknown class TYPO3\\\\CMS\\\\Backend\\\\Controller\\\\Event\\\\RenderAdditionalContentToRecordListEvent\\.$#"
-			count: 1
-			path: ../Classes/Listener/RenderAdditionalContentToRecordList.php
-
-		-
-			message: "#^Parameter \\$event of method T3G\\\\AgencyPack\\\\Blog\\\\Listener\\\\RenderAdditionalContentToRecordList\\:\\:__invoke\\(\\) has invalid type TYPO3\\\\CMS\\\\Backend\\\\Controller\\\\Event\\\\RenderAdditionalContentToRecordListEvent\\.$#"
-			count: 1
-			path: ../Classes/Listener/RenderAdditionalContentToRecordList.php
+			path: ../Classes/Domain/Repository/PostRepository.php

Classes/Controller/PostController.php

@@ -59,7 +59,7 @@ public function __construct(
     }
 
     /**
-     * @param ViewInterface|\TYPO3\CMS\Extbase\Mvc\View\ViewInterface $view
+     * @param ViewInterface $view
      */
     protected function initializeView($view): void
     {

Classes/Domain/Model/Author.php

@@ -54,8 +54,10 @@ public function initializeObject(): void
 
     public function getAvatarProvider(): AvatarProviderInterface
     {
-        $avatarProvider = trim($this->avatarProvider) !== ''
-            ? GeneralUtility::makeInstance($this->avatarProvider)
+        /** @var class-string<object>|'' $avatarProviderClassName */
+        $avatarProviderClassName = trim($this->avatarProvider);
+        $avatarProvider = $avatarProviderClassName !== ''
+            ? GeneralUtility::makeInstance($avatarProviderClassName)
             : GeneralUtility::makeInstance(GravatarProvider::class);
 
         if (!$avatarProvider instanceof AvatarProviderInterface) {

Classes/Domain/Validator/GoogleCaptchaValidator.php

@@ -19,7 +19,7 @@ class GoogleCaptchaValidator extends AbstractValidator
 {
     protected $acceptsEmptyValues = false;
 
-    public function isValid($value): void
+    public function isValid(mixed $value): void
     {
         $action = 'form';
         $controller = 'Comment';

Classes/Listener/ModifyPageLayoutContent.php

@@ -23,7 +23,7 @@ public function __construct(BlogPostHeaderContentRenderer $blogPostHeaderContent
         $this->blogPostHeaderContentRenderer = $blogPostHeaderContentRenderer;
     }
 
-    public function __invoke(ModifyPageLayoutContentEvent $event)
+    public function __invoke(ModifyPageLayoutContentEvent $event): void
     {
         $request = $event->getRequest();
         $content = $this->blogPostHeaderContentRenderer->render($request);

Classes/Notification/NotificationManager.php

@@ -35,6 +35,7 @@ public function notify(NotificationInterface $notification): void
         $notificationId = $notification->getNotificationId();
         if (\is_array($this->visitorsRegistry[$notificationId] ?? null)) {
             foreach ($this->visitorsRegistry[$notificationId] as $visitorClassName) {
+                /** @var class-string<object> $visitorClassName */
                 $instance = GeneralUtility::makeInstance($visitorClassName);
                 if ($instance instanceof ProcessorInterface) {
                     $instance->process($notification);

Tests/Functional/AvatarProvider/GravatarProviderTest.php

@@ -31,6 +31,7 @@ class GravatarProviderTest extends FunctionalTestCase
 
     public function testGetAvatarUrlReturnsOriginalGravatarComUrl(): void
     {
+        /** @phpstan-ignore-next-line */
         $frontendTypoScript = new FrontendTypoScript(new RootNode(), [], [], []);
         $frontendTypoScript->setSetupArray([]);
         $request = (new ServerRequest())
@@ -49,6 +50,7 @@ public function testGetAvatarUrlReturnsOriginalGravatarComUrl(): void
     public function testGetAvatarUrlReturnsTypo3TempUrl(): void
     {
         $GLOBALS['TYPO3_CONF_VARS']['EXTENSIONS']['blog']['enableGravatarProxy'] = '1';
+        /** @phpstan-ignore-next-line */
         $frontendTypoScript = new FrontendTypoScript(new RootNode(), [], [], []);
         $frontendTypoScript->setSetupArray([]);
         $request = (new ServerRequest())

Tests/Functional/SiteBasedTestCase.php

@@ -66,8 +66,10 @@ protected function createTestSite(): void
 
         GeneralUtility::rmdir($this->instancePath . '/typo3conf/sites/' . $identifier, true);
         if ((new Typo3Version())->getMajorVersion() >= 13) {
+            /** @phpstan-ignore-next-line */
             $this->get(SiteWriter::class)->write($identifier, $configuration);
         } else {
+            /** @phpstan-ignore-next-line */
             $this->get(SiteConfiguration::class)->write($identifier, $configuration);
         }
     }

Tests/Functional/ViewHelpers/GravatarViewHelperTest.php

@@ -36,6 +36,7 @@ final class GravatarViewHelperTest extends FunctionalTestCase
     #[DataProvider('renderDataProvider')]
     public function render(string $template, string $expected): void
     {
+        /** @phpstan-ignore-next-line */
         $frontendTypoScript = new FrontendTypoScript(new RootNode(), [], [], []);
         $frontendTypoScript->setSetupArray([]);
         $request = (new ServerRequest())

Tests/Functional/ViewHelpers/Uri/AvatarViewHelperTest.php

@@ -37,6 +37,7 @@ final class AvatarViewHelperTest extends FunctionalTestCase
     #[DataProvider('renderDataProvider')]
     public function render(string $template, string $expected): void
     {
+        /** @phpstan-ignore-next-line */
         $frontendTypoScript = new FrontendTypoScript(new RootNode(), [], [], []);
         $frontendTypoScript->setSetupArray([]);
         $request = (new ServerRequest())