Skip to content

Commit

Permalink
[!!!][TASK] Drop social share options
Browse files Browse the repository at this point in the history
The social share links are rarely used and no implementation is provided
by the blog extension itself. The option is removed without replacement.
  • Loading branch information
benjaminkott committed Aug 19, 2019
1 parent 06ed9f2 commit 8a34e35
Show file tree
Hide file tree
Showing 9 changed files with 6 additions and 60 deletions.
25 changes: 0 additions & 25 deletions Classes/Domain/Model/Post.php
Original file line number Diff line number Diff line change
Expand Up @@ -94,13 +94,6 @@ class Post extends AbstractEntity
*/
protected $tags;

/**
* Sharing enabled flag for this blog post. This flag can be used in views to enable sharing tools.
*
* @var bool
*/
protected $sharingEnabled;

/**
* @var \TYPO3\CMS\Extbase\Persistence\ObjectStorage<\TYPO3\CMS\Extbase\Domain\Model\FileReference>
* @Extbase\ORM\Lazy
Expand Down Expand Up @@ -397,24 +390,6 @@ public function removeComment(Comment $comment): self
return $this;
}

/**
* @return bool
*/
public function isSharingEnabled(): bool
{
return $this->sharingEnabled;
}

/**
* @param bool $sharingEnabled
* @return Post
*/
public function setSharingEnabled(bool $sharingEnabled): self
{
$this->sharingEnabled = $sharingEnabled;
return $this;
}

/**
* @return ObjectStorage
*/
Expand Down
3 changes: 1 addition & 2 deletions Configuration/DataHandler/BlogSetupRecords.php
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,7 @@
plugin.tx_blog.settings.authorUid = NEW_blogAuthorPage
plugin.tx_blog.settings.archiveUid = NEW_blogArchivePage
plugin.tx_blog.settings.storagePid = NEW_blogFolder',
'config' => 'plugin.tx_blog.settings.sharing.enabled = 0
page = PAGE
'config' => 'page = PAGE
page.10 < styles.content.get',
'description' => 'This is your blog template',
];
Expand Down
10 changes: 1 addition & 9 deletions Configuration/TCA/Overrides/pages.php
Original file line number Diff line number Diff line change
Expand Up @@ -87,14 +87,6 @@
],
],
],
'sharing_enabled' => [
'exclude' => 1,
'label' => $ll . 'pages.sharing_enabled',
'config' => [
'type' => 'check',
'default' => '1',
],
],
'crdate_month' => [
'exclude' => 1,
'label' => $ll . 'pages.crdate_month',
Expand Down Expand Up @@ -201,7 +193,7 @@
\TYPO3\CMS\Core\Utility\ExtensionManagementUtility::addToAllTCAtypes(
'pages',
'--div--;' . $ll . 'pages.tabs.blog,
--palette--;' . $ll . 'pages.palettes.publish_date;publish_date, archive_date, tags, authors, comments_active, comments, sharing_enabled',
--palette--;' . $ll . 'pages.palettes.publish_date;publish_date, archive_date, tags, authors, comments_active, comments',
(string) \T3G\AgencyPack\Blog\Constants::DOKTYPE_BLOG_POST
);

Expand Down
4 changes: 0 additions & 4 deletions Configuration/TypoScript/Static/setup.typoscript
Original file line number Diff line number Diff line change
Expand Up @@ -235,10 +235,6 @@ plugin.tx_blog {
stdWrap.wrap = <h1>|</h1>
stdWrap.typolink.parameter.data = page:uid
}
pageInfo.sharingEnabled = TEXT
pageInfo.sharingEnabled {
data = page:sharing_enabled
}
}


Expand Down
8 changes: 1 addition & 7 deletions Documentation/Administrators/Index.rst
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ categories, tags and archive links.

Metadata
""""""""
Displays post meta data, like date, tags, category, sharing links...
Displays post meta data, like date, tags, category...


Authors
Expand Down Expand Up @@ -244,12 +244,6 @@ Tags are blog specific records. Creating a new tag works in the same way as crea
* Click "Save"


Enable sharing
--------------

To enable sharing go to the page properties of your blog entry and set the check box "Sharing enabled"


AvatarProvider
--------------

Expand Down
5 changes: 0 additions & 5 deletions Documentation/Basics/Index.rst
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,3 @@ Categorizing and Tagging
Use categories and tags to add meta information to your blog posts. Let your users explore your posts based on their interests
navigating via tags or categories to find similar entries. Add posts from the same category to your posts to get your readers
to read even more.


Be social - share your posts
----------------------------
Enable sharing in the commonly used social networks by enabling a single checkbox.
5 changes: 2 additions & 3 deletions Documentation/Editors/Index.rst
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,7 @@ To create a new post, follow these steps:
7. Click on tab "Blog"
8. Choose tags for your blog post
9. Choose if you want to enable comments
10. Choose if you want to enable sharing
11. Define an archive date if your want to remove a blog post by given date from the main list (not for tag, category, date or archive lists)
10. Define an archive date if your want to remove a blog post by given date from the main list (not for tag, category, date or archive lists)

.. note::

Expand Down Expand Up @@ -66,4 +65,4 @@ Set a details page for an author

1. Go to the properties page of an author
2. Click on the "Blog data" tab
3. Set a details page for the author to link to as it's details page
3. Set a details page for the author to link to as it's details page
5 changes: 1 addition & 4 deletions Resources/Private/Language/locallang_db.xlf
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@
<source>Blog: Metadata (Deprecated, will be removed with v11)</source>
</trans-unit>
<trans-unit id="plugin.blog_metadata.description" xml:space="preserve">
<source>Displays post meta data, like date, tags, category, sharing links...</source>
<source>Displays post meta data, like date, tags, category...</source>
</trans-unit>
<trans-unit id="plugin.blog_commentform.title" xml:space="preserve">
<source>Blog: Comment Form</source>
Expand Down Expand Up @@ -116,9 +116,6 @@
<trans-unit id="pages.authors" xml:space="preserve">
<source>Authors</source>
</trans-unit>
<trans-unit id="pages.sharing_enabled" xml:space="preserve">
<source>Sharing enabled (show sharing links)</source>
</trans-unit>
<trans-unit id="pages.tabs.blog" xml:space="preserve">
<source>Blog</source>
</trans-unit>
Expand Down
1 change: 0 additions & 1 deletion ext_tables.sql
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,6 @@ CREATE TABLE tx_blog_domain_model_comment (
#
CREATE TABLE pages (
comments_active tinyint(4) DEFAULT '1' NOT NULL,
sharing_enabled tinyint(4) DEFAULT '1' NOT NULL,
publish_date int(11) DEFAULT '0' NOT NULL,
archive_date int(11) DEFAULT '0' NOT NULL,
crdate_month int(11) DEFAULT '0' NOT NULL,
Expand Down

0 comments on commit 8a34e35

Please sign in to comment.