[TASK] Remove unreachable else because ternary operator condition is …

…always true
TYPO3GmbH · Jan 8, 2021 · 8767b93 · 8767b93
1 parent 40f4bca
commit 8767b93
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 6 deletions.
diff --git a/Classes/ViewHelpers/Link/Be/AuthorViewHelper.php b/Classes/ViewHelpers/Link/Be/AuthorViewHelper.php
@@ -51,7 +51,7 @@ public function render(): string
     {
         /** @var Author $author */
         $author = $this->arguments['author'];
-        $authorUid = $author !== null ? (int)$author->getUid() : 0;
+        $authorUid = (int)$author->getUid();
 
         $routingUriBuilder = GeneralUtility::makeInstance(UriBuilder::class);
         $uri = $routingUriBuilder->buildUriFromRoute('record_edit', ['edit[tx_blog_domain_model_author][' . $authorUid . ']' => 'edit']);

diff --git a/Classes/ViewHelpers/Link/Be/CategoryViewHelper.php b/Classes/ViewHelpers/Link/Be/CategoryViewHelper.php
@@ -51,7 +51,7 @@ public function render(): string
     {
         /** @var Category $category */
         $category = $this->arguments['category'];
-        $categoryUid = $category !== null ? (int)$category->getUid() : 0;
+        $categoryUid = (int)$category->getUid();
 
         $routingUriBuilder = GeneralUtility::makeInstance(UriBuilder::class);
         $uri = $routingUriBuilder->buildUriFromRoute('record_edit', ['edit[sys_category][' . $categoryUid . ']' => 'edit']);

diff --git a/Classes/ViewHelpers/Link/Be/CommentViewHelper.php b/Classes/ViewHelpers/Link/Be/CommentViewHelper.php
@@ -51,7 +51,7 @@ public function render(): string
     {
         /** @var Comment $comment */
         $comment = $this->arguments['comment'];
-        $commentUid = $comment !== null ? (int)$comment->getUid() : 0;
+        $commentUid = (int)$comment->getUid();
 
         $routingUriBuilder = GeneralUtility::makeInstance(UriBuilder::class);
         $uri = $routingUriBuilder->buildUriFromRoute('record_edit', ['edit[tx_blog_domain_model_comment][' . $commentUid . ']' => 'edit']);

diff --git a/Classes/ViewHelpers/Link/Be/PostViewHelper.php b/Classes/ViewHelpers/Link/Be/PostViewHelper.php
@@ -51,7 +51,7 @@ public function render(): string
     {
         /** @var Post $post */
         $post = $this->arguments['post'];
-        $pageUid = $post !== null ? (int)$post->getUid() : 0;
+        $pageUid = (int)$post->getUid();
 
         $uriBuilder = GeneralUtility::makeInstance(UriBuilder::class);
         switch ($this->arguments['action']) {

diff --git a/Classes/ViewHelpers/Link/Be/TagViewHelper.php b/Classes/ViewHelpers/Link/Be/TagViewHelper.php
@@ -51,7 +51,7 @@ public function render(): string
     {
         /** @var Tag $tag */
         $tag = $this->arguments['tag'];
-        $tagUid = $tag !== null ? (int)$tag->getUid() : 0;
+        $tagUid = (int)$tag->getUid();
 
         $routingUriBuilder = GeneralUtility::makeInstance(UriBuilder::class);
         $uri = $routingUriBuilder->buildUriFromRoute('record_edit', ['edit[tx_blog_domain_model_tag][' . $tagUid . ']' => 'edit']);

diff --git a/Classes/ViewHelpers/Link/PostViewHelper.php b/Classes/ViewHelpers/Link/PostViewHelper.php
@@ -49,7 +49,7 @@ public function render(): string
         /** @var Post $post */
         $post = $this->arguments['post'];
         $section = $this->arguments['section'] ?: '';
-        $pageUid = $post !== null ? (int)$post->getUid() : 0;
+        $pageUid = (int) $post->getUid();
         $uriBuilder = $this->renderingContext->getControllerContext()->getUriBuilder();
         $createAbsoluteUri = (bool)$this->arguments['createAbsoluteUri'];
         $uri = $uriBuilder->reset()