Skip to content

Commit

Permalink
[BUGFIX] Replace legacy bootstrap classes supported by FontAwesome
Browse files Browse the repository at this point in the history
FontAwesome provides CSS classes that align with the old Bootstrap v3
classes, which will cause troubles with the removal of FontAwesome.
As another preparation task, those classes are be replaced with the
according Bootstrap classes.

Classes replaced:

* pull-left -> float-start
* pull-right -> float-end
* sr-only -> visually-hidden

Resolves: #98064
Resolves: #94531
Releases: main, 11.5
Change-Id: I4e96572e6b3a0007a7bf68f3018934f73da6249b
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75344
Tested-by: core-ci <[email protected]>
Tested-by: Oliver Bartsch <[email protected]>
Tested-by: Stefan Kapitza <[email protected]>
Tested-by: Andreas Fernandez <[email protected]>
Reviewed-by: Oliver Bartsch <[email protected]>
Reviewed-by: Georg Ringer <[email protected]>
Reviewed-by: Stefan Kapitza <[email protected]>
Reviewed-by: Andreas Fernandez <[email protected]>
  • Loading branch information
andreaskienast committed Aug 5, 2022
1 parent 6ea616e commit b7e0cfd
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Classes/Controller/SetupModuleController.php
Original file line number Diff line number Diff line change
Expand Up @@ -473,7 +473,7 @@ class="form-check-input"
' width="' . (int)$avatarImage->getWidth() . '" ' .
'height="' . (int)$avatarImage->getHeight() . '" />' .
'</span></span>';
$html .= '<span class="pull-left" style="padding-right: 10px" id="image_' . htmlspecialchars($fieldName) . '">' . $icon . ' </span>';
$html .= '<span class="float-start" style="padding-right: 10px" id="image_' . htmlspecialchars($fieldName) . '">' . $icon . ' </span>';
}
}
$html .= '<input id="field_' . htmlspecialchars($fieldName) . '" type="hidden" ' .
Expand Down

0 comments on commit b7e0cfd

Please sign in to comment.