Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Jekyll build to latest Ruby 3.2.2 from 2.7.8 (keep fontcustom on 2.7.8) #31

Merged
merged 6 commits into from
Nov 12, 2023

Conversation

TWiStErRob
Copy link
Owner

@TWiStErRob TWiStErRob commented Oct 25, 2023

Jekyll 3.9.3 runs on Ruby 2.7.8 or 3.2.2 too.
Fontcustom 2.0.0 only runs on Ruby 2.7.8, because of the following errors:

Content changes: '' in generated XML files.

The rest of the conversation are deprecations, which I'll leave for now, as I want to see what's the state after Jekyll 4.

Copy link
Owner Author

@TWiStErRob TWiStErRob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some messages after a fresh lock-less install.

@@ -1 +1 @@
2.7.8
3.2.2
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Calling DidYouMean::SPELL_CHECKERS.merge!(error_name => spell_checker)' has been deprecated. Please call DidYouMean.correct_error(error_name, spell_checker)' instead.

.ruby-version Show resolved Hide resolved
.ruby-version Show resolved Hide resolved
@@ -1 +1 @@
2.7.8
3.2.2
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Post-install message from sass:

Ruby Sass has reached end-of-life and should no longer be used.

@@ -1 +1 @@
2.7.8
3.2.2
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Post-install message from html-pipeline:
-------------------------------------------------
Thank you for installing html-pipeline!
You must bundle Filter gem dependencies.
See html-pipeline README.md for more details.
https://github.com/jch/html-pipeline#dependencies
-------------------------------------------------

@@ -1 +1 @@
2.7.8
3.2.2
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Post-install message from rubyzip:
RubyZip 3.0 is coming!
**********************

The public API of some Rubyzip classes has been modernized to use named
parameters for optional arguments. Please check your usage of the
following classes:

  • Zip::File
  • Zip::Entry
  • Zip::InputStream
  • Zip::OutputStream

Please ensure that your Gemfiles and .gemspecs are suitably restrictive
to avoid an unexpected breakage when 3.0 is released (e.g. ~> 2.3.0).
See https://github.com/rubyzip/rubyzip for details. The Changelog also
lists other enhancements and bugfixes that have been implemented since
version 2.3.0.

@TWiStErRob TWiStErRob mentioned this pull request Nov 12, 2023
3 tasks
@TWiStErRob TWiStErRob added the content-change Instructs CI to skip verifying contents of the site. label Nov 12, 2023
@TWiStErRob TWiStErRob changed the title Upgrade to latest Ruby Upgrade Jekyll build to latest Ruby 3.2.2 from 2.7.8 (keep fontcustom on 2.7.8) Nov 12, 2023
@TWiStErRob TWiStErRob merged commit ebc93f6 into main Nov 12, 2023
7 of 8 checks passed
@TWiStErRob TWiStErRob deleted the ruby branch November 12, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content-change Instructs CI to skip verifying contents of the site.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant