Using AuthCache for Apache HttpClient to do pre-emptive authentication #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sagarsane
force-pushed
the
84-fix-authentication-for-publish
branch
from
19fb07b to
f0df1f9
Compare
| private HttpClientContext getHttpClientContext(HttpGet get) { | ||
| // Setup preemptive Authentication | ||
| // Create AuthCache instance | ||
| AuthCache authCache = new BasicAuthCache(); |
There was a problem hiding this comment.
@sagarsane Minor: semi-colons can be removed from end of lines. +1 otherwise
sagarsane
force-pushed
the
84-fix-authentication-for-publish
branch
from
f0df1f9 to
529d6f3
Compare
sagarsane
changed the title
|
@sikarwarvimal @kyleabaker @jdigger @jbornemann this is ready for review and testing. This will need a |
| * Gets a new HttpClientContext for the given HttpRequest. The ClientContext sets up preemptive | ||
| * authentication using BasicAuthCache | ||
| * @param get the HttpGet request | ||
| * @return |
There was a problem hiding this comment.
empty @return. either populate or remove
|
Besides some stylistic comments, +1 CR. Have not tested. |
sagarsane
force-pushed
the
84-fix-authentication-for-publish
branch
from
529d6f3 to
8e8e4bf
Compare
|
Updated with CR comments. |
sagarsane
force-pushed
the
84-fix-authentication-for-publish
branch
from
8e8e4bf to
fd3d7fe
Compare
|
+1 testing |
sagarsane
force-pushed
the
84-fix-authentication-for-publish
branch
from
fd3d7fe to
008b459
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to clean the code up a bit
For #84