Fix date and datetime conversion for numpy scalars #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julian2date and julian2datetime behave now the same when scalar values are passed, no matter the underlying dataformat. Single element numpy arrays, however, still produce array outputs as expected Tests have been added to regress and document this behaviour.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently ran into the problem that juliand2datetime would crash when juliand2datetime is invoked with a numpy scalar.
Steps to reproduce:
This is because julian2date behaves like it would receive an array type and returns arrays which julian2datetime is not expecting.
I propose to harmonise the behaviour of julian2date so it behaves the same for all scalar types no matter the format.
Tests have been added to regress and document this behaviour.