Skip to content
This repository has been archived by the owner on Jan 10, 2024. It is now read-only.

Exact Average Grade Implementation #543

Merged
merged 11 commits into from
Jun 21, 2023
Merged

Conversation

Antonwy
Copy link
Contributor

@Antonwy Antonwy commented May 23, 2023

Changes

  • Restructured GradesView into multiple smaller components => DegreeGradesView & SemesterGradesView
  • Implemented & fetched average grade from TUMOnline API

Screenshots

Screenshot 2023-05-23 at 17 35 33@2x

@Antonwy Antonwy changed the base branch from main to development May 23, 2023 15:37
@14slash12
Copy link
Contributor

LGTM, but should also be approved by another reviewer.

This should (if feasible) not be merged before #540, to not inject another bulk of conflicts.

Thanks 😊

Copy link
Member

@philippzagar philippzagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good to me, just some minor improvement suggestions. Thanks!

@Antonwy Antonwy requested a review from philippzagar June 9, 2023 17:04
@AW-tum AW-tum merged commit 9a2ca07 into development Jun 21, 2023
@AW-tum AW-tum deleted the feature/average-grade branch June 21, 2023 13:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants