Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tte sign testbranch #16

Merged
merged 161 commits into from
Sep 17, 2024
Merged

Tte sign testbranch #16

merged 161 commits into from
Sep 17, 2024

Conversation

DerToaster98
Copy link
Member

Merge sign testbranch

@DerToaster98
begin new sign API
ed29a0a
@DerToaster98
add base class for signs and registration
0825279
@DerToaster98
add craft sign => For stuff like cruise signs or remote signs
b66b5e0
@DerToaster98
implement listener that calls the individual registered signs
6a3ad90
@DerToaster98
add base for cruise-like signs
9ca4816
@DerToaster98
add overloaded internalProcessing method for craftsigns
c80df99
@DerToaster98
add method to get ident of sign instance
07e829e
@DerToaster98
call detect event with the sign
edbd6ef
@DerToaster98
migrate name sign to new sign API
0b3f467
@DerToaster98
organize imports
95cbe5b
@DerToaster98
reimplement release sign with new sign api
f82bb7b
@DerToaster98
reimplement scuttle sign with new sign API
4692881
@DerToaster98
register release and scuttle signs
08611a9
@DerToaster98
migrate Move and RMove signs
d4f9cbb
@DerToaster98
move perm check to canPlayerUseOn
8f92799
@DerToaster98
migrate helm sign
81cf5a9 
it is a bit ugly to register it twice but i think that's just alright. Alternatively we could just create a empty sign change listener for the [Helm] stuff and roll with that
@DerToaster98
rename method to "onCraftisBusy" is it isn't always a parent craft bu…
99aa146 
…t the craft that the sign is on
@DerToaster98
allow double colons in idents
a66a0af
@DerToaster98
add comment for later
c4623f5
@DerToaster98
make sign listener abstract and add abstraction layer to signs
9575095
@DerToaster98
initialize sign listener like the version specific stuff
2997b1e
@DerToaster98
refactor sign base classes to use the abstraction class
604abeb
@DerToaster98
add base for info signs
c1bf27d
@DerToaster98
refactors
0edd8cb
@DerToaster98
add 1.21 implementation of signlistener
d679689
@DerToaster98
fix imports
02fe15e
@DerToaster98
add 1.20 implementation of listener
ef9ca4b
@DerToaster98
add 1.18 signListener implementation
383683e
@DerToaster98
migrate teleport sign and fix move sign
f8e6c02
@DerToaster98
fix helm sign
7260f9d
@DerToaster98
small tweaks regarding interactions
6a09a70
@DerToaster98
shorten fuel string length
d912af5
@DerToaster98
shorten text
a2c4691
@DerToaster98
NPE prevention
8e7f1bf
@DerToaster98
shrink string more
82d4693
@DerToaster98
respect edits with dyecolors, wax, etc
08b4e6d
@DerToaster98
kilo, million, billion, trillion fuel
bf9f926
@DerToaster98
extract base elements from Cruise sign into a toggle sign
e3a730c
@DerToaster98
replacement for resetSigns => DO NOT MERGE INTO API YET
e06e37e
@DerToaster98
update signs after detect
a426bcf
@DerToaster98
fix indexOutOfBoundsException
088ca62
@DerToaster98
forgot facing check in cruise sign
74d103f
@DerToaster98
reset columns when switiching lines
64dcadb
@DerToaster98
cancel sign clicks on crafts in all cases
869cb5a
@DerToaster98
only cancel when sign is empty
c345a25
@DerToaster98
properly toggle other signs off
481948b
@DerToaster98
also return true in that case, otherwise no update
9b29de6
@DerToaster98
allow toggle signs to decide if they are resetted by a different togg…
ff7c777 
…le sign
@DerToaster98
remove version specific versions of the signListener as 1.18 is gone …
9f3eb36 
…now. No longer create SignTranslateEvent but still react to it
@DerToaster98
adapt to refactoring
dc459d2
@DerToaster98
adapt remaining implementations to refactor
60959b1
@DerToaster98
use newer method
77bb394
@DerToaster98
fix compile errors and remove old code
b09af7b
@DerToaster98
fix override param
834794f
@DerToaster98
fix subcraft sign creation
2454f78
@DerToaster98
apply default text and implement processSignChange
397e7fe
@DerToaster98
correct typo
441452c
@DerToaster98
return true
0433e31
@DerToaster98
call stuff for the other side, if that side is a movecraft sign
0ce7710
@DerToaster98 DerToaster98 merged commit 04ec930 into tte Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@DerToaster98