Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(german-guide): Scoring Adjustments #2225

Merged
merged 2 commits into from
Jan 20, 2025

Conversation

Lokilicious
Copy link
Contributor

@Lokilicious Lokilicious commented Jan 17, 2025

Pull Request

Purpose

We noticed 2 problems:

  1. Since the maximum possible score of the German Guide is >30k a penalty of -10k as defined from the international guide was not enough to block releases.
  2. The difference between German and German DL of only 1 point could lead to "downgrades" from German DL to German with a simple repack.

Approach

To address 2: we increase the score of German DL to 11000. The gap of 1000 should be enough to cover typical score increments. To still allow proper upgrades between qualities we had to adjust their scores as well.

To address 1: we increase the penalty for all “blocking” CFs to -35k exclusively for the german guide by using the german score_set in the CFs json.

Requirements

@Lokilicious Lokilicious requested a review from yammes08 January 17, 2025 06:31
@github-actions github-actions bot added Area: Sonarr Sonarr Related Area: Radarr Radarr Related Area: Backend Backend Changes, not related to a specific section Area: Starr Custom Formats Issue is related to custom formats labels Jan 17, 2025
@Lokilicious Lokilicious requested a review from TRaSH- January 17, 2025 06:31
@TRaSH- TRaSH- merged commit 24e46e4 into master Jan 20, 2025
11 checks passed
@TRaSH- TRaSH- deleted the fix/german-guide-scoring-adjustments branch January 20, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Backend Backend Changes, not related to a specific section Area: Radarr Radarr Related Area: Sonarr Sonarr Related Area: Starr Custom Formats Issue is related to custom formats
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants