fix(german-guide): Scoring Adjustments #2225
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Purpose
We noticed 2 problems:
Approach
To address 2: we increase the score of German DL to 11000. The gap of 1000 should be enough to cover typical score increments. To still allow proper upgrades between qualities we had to adjust their scores as well.
To address 1: we increase the penalty for all “blocking” CFs to -35k exclusively for the german guide by using the german score_set in the CFs json.
Requirements