Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(starr): add MultiSub and Multiple Subtitle to Anime Web Tier 04 Custom Format #2216

Conversation

dzaqwan
Copy link

@dzaqwan dzaqwan commented Jan 12, 2025

Pull Request

Purpose

Sometimes starr apps fetch release from Erai-raws that is raw or does not have English subtitle

Approach

Add regex lookaround for [Multiple Subtitle] or [MultiSub]

image

Open Questions and Pre-Merge TODOs

None

Requirements

@github-actions github-actions bot added Area: Sonarr Sonarr Related Area: Radarr Radarr Related Area: Backend Backend Changes, not related to a specific section Area: Starr Custom Formats Issue is related to custom formats labels Jan 12, 2025
@TRaSH- TRaSH- requested a review from a team January 12, 2025 12:13
@rg9400
Copy link
Contributor

rg9400 commented Jan 13, 2025

Unforunately, we had to roll back a similar approach we used to do for VARYG. First, there are a variety of subbed Erai-Raws releases that do not contain this string. Just checking the releases from the last 2-3 days and I saw Detective Conan and Beheneko and One Piece Log all missing this string. Next, there will be a variety of reuploads where they strip out this string from the naming, preventing it from matching. Finally, with season packs, this string might not be in the filename always even if it is in the release name, causing download loops.

Trust me, I wanted to do the same thing with VARYG, but it resulted in a ton of support and questions, which is why we removed it. Instead, it is much easier to tell people to ensure their Nyaa is set to the English-translated category and deal with the one-off rare cases where these groups upload raws. Erai has 94 raw releases, an incredibly tiny percentage of their releases, meaning I do not think it is worth solving for those cases and better to just manually intervene when those happen. In terms of support, there has been close to no help needed with VARYG after the rollback whereas when it required this type of string, it caused issues almost every day.

@dzaqwan
Copy link
Author

dzaqwan commented Jan 13, 2025

@rg9400 Ah somehow I missed it. Thanks for the review anyway!

@dzaqwan dzaqwan closed this Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Backend Backend Changes, not related to a specific section Area: Radarr Radarr Related Area: Sonarr Sonarr Related Area: Starr Custom Formats Issue is related to custom formats
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants