Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(starr-anime): Remove unnecessary anime remux groups, move top remux groups to higher tiers, add NAN0 and VULCAN #2177

Merged
merged 11 commits into from
Dec 26, 2024

Conversation

rg9400
Copy link
Contributor

@rg9400 rg9400 commented Dec 24, 2024

Pull Request

Purpose

Removing a variety of anime remux groups that do not have a single release marked as Best on SeaDex. Adding VULCAN to the remux tier since they have a few best releases. Moving ZR to tier 3 because of huge number of best releases. Moving Dragon-Releases to tier 4 for having 10+ best releases. Adding NAN0 to tier 4 for being a remux group with 10+ best releases. TTGA has over 50 best releases, but they are almost exclusively when the alternative is WEB only. For now, we can keep them in tier 5 so they get trumped by better encodes.

Count per Ravencentric:

{'ANThELIa': 0, 'BluDragon': 4, 'D4C': 5, 'Dragon-Releases': 11, 'E.N.D': 1, 'KAWAiREMUX': 0, 'MKVULTRA': 0, 'Raizel': 2, 'REVO': 9, 'Spark': 0, 'SRLS': 2, 'ZR': 0, '-ZR-': 151, 'NAN0': 15, 'VULCAN': 3, 'FraMeSToR': 8, 'TTGA': 49}

Approach

I reordered Tier 3 in both Radarr and Sonarr because they were not alphabetical. Otherwise, standard regex. I did add an extra condition for ZR to capture -ZR-

Requirements

@github-actions github-actions bot added Area: Radarr Radarr Related Area: Backend Backend Changes, not related to a specific section Area: Starr Custom Formats Issue is related to custom formats labels Dec 24, 2024
Copy link
Contributor

@rg9400 your pull request title "Remove groups from anime remux tier" does not conform to our naming conventions.

Please update the title to match the pattern: "feat|build|chore|style|fix|update|ci(<area>): <description>

You can check your title at this regex101 link."

@github-actions github-actions bot added the Area: Sonarr Sonarr Related label Dec 24, 2024
@rg9400 rg9400 changed the title Remove groups from anime remux tier feat(starr-anime): Remove unnecessary anime remux groups, move top remux groups to higher tiers, add NAN0 and VULCAN Dec 24, 2024
Copy link
Contributor

@TRaSH- TRaSH- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two lines needs to be removed

Copy link
Contributor

@FonduemangVI FonduemangVI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go

@FonduemangVI FonduemangVI merged commit 910c342 into master Dec 26, 2024
11 checks passed
@FonduemangVI FonduemangVI deleted the rg9400-patch-1 branch December 26, 2024 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Backend Backend Changes, not related to a specific section Area: Radarr Radarr Related Area: Sonarr Sonarr Related Area: Starr Custom Formats Issue is related to custom formats
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants