Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(guide): Upscaled - Update Custom Format #2125

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ThisIsJeron
Copy link

@ThisIsJeron ThisIsJeron commented Oct 31, 2024

Pull Request

Purpose

Upscaled is missing a couple AI tags for releases it automatically pulls

Approach

Add new regex to the json for both Sonarr and Radarr

Open Questions and Pre-Merge TODOs

Requirements

@github-actions github-actions bot added Area: Sonarr Sonarr Related Area: Radarr Radarr Related Area: Backend Backend Changes, not related to a specific section Area: Starr Custom Formats Issue is related to custom formats labels Oct 31, 2024
@TRaSH- TRaSH- requested a review from a team November 2, 2024 19:00
"negate": false,
"required": false,
"fields": {
"value": "\\.Ai\\."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is too generic and will trigger on any episode or movie title with AI in the name

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's a good point, did not consider that. Will update when I get the chance or if someone would like to directly commit to the PR that would be great too

Copy link
Contributor

@bakerboy448 bakerboy448 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with rg unless there's sufficient test cases to prove otherwise

@bakerboy448 bakerboy448 added Status: Waiting for User Waiting for OP or Contributor to address feedback or provide information Do Not Merge Do Not Merge labels Nov 21, 2024
@bakerboy448 bakerboy448 marked this pull request as draft December 3, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Backend Backend Changes, not related to a specific section Area: Radarr Radarr Related Area: Sonarr Sonarr Related Area: Starr Custom Formats Issue is related to custom formats Do Not Merge Do Not Merge Status: Waiting for User Waiting for OP or Contributor to address feedback or provide information
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants