Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(guide): include the different hdr formats in the quality profiles #1623

Conversation

TRaSH-
Copy link
Contributor

@TRaSH- TRaSH- commented Nov 11, 2023

Pull Request

Purpose

Hopefully to improve the readability of the guide for the HDR formats and flowchart

Also fixes the following
Fix: #1613

Approach

Included all the 3 HDR Format option in the quality profile guide, including a description which to choose together with the HDR flowchart, added extra info why some people get green/purple color when playing DV content.

Open Questions and Pre-Merge TODOs

  • Included all the 3 HDR Format option in the quality profile guide for Radarr
  • Included all the 3 HDR Format option in the quality profile guide for Sonarr
  • updated the Radarr flowchart
  • updated the Sonarr flowchart
  • updated the SQP flowcharts
  • add extra info about the supports profiles and CMv for the AppleTV to the public Quality Profiles
  • add extra info about the supports profiles and CMv for the AppleTV to SQP

Requirements

@TRaSH- TRaSH- marked this pull request as draft November 11, 2023 13:00
@github-actions github-actions bot added the Area: Radarr Radarr Related label Nov 11, 2023
@github-actions github-actions bot added the Area: Sonarr Sonarr Related label Nov 11, 2023
yammes08
yammes08 previously approved these changes Nov 14, 2023
Copy link
Contributor

@yammes08 yammes08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made a couple of extra commits with changes - @TRaSH- check you're happy with them. Other than those, the rest lgtm.

@TRaSH- TRaSH- marked this pull request as ready for review November 18, 2023 17:17
Copy link
Contributor

@zakkarry zakkarry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor grammar/language modifications, overall seems pretty good otherwise.

Most are just nits and stuff.

docs/Radarr/radarr-setup-quality-profiles.md Outdated Show resolved Hide resolved
docs/Radarr/radarr-setup-quality-profiles.md Outdated Show resolved Hide resolved
docs/Radarr/radarr-setup-quality-profiles.md Outdated Show resolved Hide resolved
docs/Radarr/radarr-setup-quality-profiles.md Outdated Show resolved Hide resolved
docs/Sonarr/sonarr-setup-quality-profiles.md Outdated Show resolved Hide resolved
docs/Sonarr/sonarr-setup-quality-profiles.md Outdated Show resolved Hide resolved
docs/Sonarr/sonarr-setup-quality-profiles.md Outdated Show resolved Hide resolved
includes/cf/dv-info-green-purple.md Outdated Show resolved Hide resolved
includes/cf/dv-info-profiles.md Outdated Show resolved Hide resolved
includes/cf/radarr-all-hdr-formats.md Outdated Show resolved Hide resolved
@zakkarry zakkarry force-pushed the feat/guide-include-the-different-hdr-formats-in-the-quality-profiles branch from f1a5d2a to e15660b Compare November 18, 2023 21:35
@zakkarry zakkarry dismissed their stale review November 18, 2023 21:48

committed

@TRaSH- TRaSH- requested review from yammes08 and a team November 19, 2023 01:33
Copy link
Contributor

@zakkarry zakkarry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made the changes, so obviously approve :P

@TRaSH- TRaSH- merged commit 987ee93 into master Nov 19, 2023
15 checks passed
@TRaSH- TRaSH- deleted the feat/guide-include-the-different-hdr-formats-in-the-quality-profiles branch November 19, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Radarr Radarr Related Area: Sonarr Sonarr Related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Guides] Update SQP-1 (2160p) Flowchart with UHD Bluray Tiers
3 participants