Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review suggestion: Build script block at end of building from source section #21

Closed
shivupa opened this issue Aug 25, 2022 · 2 comments
Closed
Assignees

Comments

@shivupa
Copy link

shivupa commented Aug 25, 2022

Summary

Part of Joss Review

This tool fits very nicely within the Triqs ecosystem and its existence makes sense/does not seem redundant. The installation of solid-dmft follows a similar flow as the other tools within the ecosystem, which is nice from a user's perspective. One thing that would help slightly is a collected build script for the build from source at the end of the installation from source section. Triqs has one in the installation instructions which is little more than a collection of the instructions that preceed it, but it makes copy+pasting easier.

@the-hampel
Copy link
Member

Hi @shivupa,
we followed your advice and made a copy/paste friendly version of the install instructions: https://triqs.github.io/solid_dmft/install.html . We also link to the docker files, which hold also full installation scripts in an extra section.
Best,
Alex

@shivupa
Copy link
Author

shivupa commented Sep 19, 2022

Nice happy to see the dockerfiles as well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants