Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do the deep clone in a GH action, "doc-gen" #129

Merged

Conversation

ryo-takahashi-1206
Copy link
Collaborator

@ryo-takahashi-1206 ryo-takahashi-1206 commented Sep 14, 2022

Summary

1. Overview

2. Implementation details

  • Change actions/checkout to the deep clone in "doc-gen"
  • Not to repeat this stupid mistake, I propose to trigger "doc-gen" also at pre-merge (i.e. on.pull_request)
  • However, to avoid messy git push in GH pages, I introduce a skip condition depending on github.ref

3. Future Work

  • Fold per-tag Sphinx docs into the single GH pages like other projects

This change is Reviewable

@ryo-takahashi-1206 ryo-takahashi-1206 force-pushed the add-missing-package/rev-1 branch 11 times, most recently from 4a6683f to 9f78c53 Compare September 14, 2022 12:04
@ryo-takahashi-1206 ryo-takahashi-1206 changed the title fix: add a missin package in 'doc-gen' fix: do the deep clone in a GH action, "pull_request" Sep 15, 2022
@ryo-takahashi-1206 ryo-takahashi-1206 marked this pull request as ready for review September 15, 2022 00:44
Copy link
Collaborator

@tk-woven tk-woven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, we did have the tags, nice catch. Thank you! :lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ykkawana-woven)

Copy link
Collaborator

@tk-woven tk-woven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*didn't have

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ykkawana-woven)

@ryo-takahashi-1206 ryo-takahashi-1206 changed the title fix: do the deep clone in a GH action, "pull_request" fix: do the deep clone in a GH action, "doc-gen" Sep 15, 2022
@ryo-takahashi-1206 ryo-takahashi-1206 merged commit 002b1a8 into TRI-ML:master Sep 15, 2022
@ryo-takahashi-1206 ryo-takahashi-1206 deleted the add-missing-package/rev-1 branch September 15, 2022 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants