Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ugly workaround for #46 #47

Merged
merged 4 commits into from
Nov 28, 2024
Merged

Ugly workaround for #46 #47

merged 4 commits into from
Nov 28, 2024

Conversation

ThomasTNO
Copy link
Contributor

Closes #46

@grebnetiew, getting our own executor seems more and more relevant to make our code stable and comprehensible..

Ideally we would move all this logic (including catching crtl+c and (near instant) exiting) to such executor.

@ThomasTNO ThomasTNO requested a review from grebnetiew November 8, 2024 18:15
Copy link

github-actions bot commented Nov 8, 2024

Sigrid maintainability feedback

✅ You wrote maintainable code and achieved your Sigrid objective of 3.5 stars

Show details

Sigrid compared your code against the baseline of 2024-11-07.

👍 What went well?

You fixed or improved 0 refactoring candidates.

👎 What could be better?

Unfortunately, 1 refactoring candidates were introduced or got worse.

Risk System property Location
🔴 Duplication
(Introduced)
WuppieFuzz/src/state.rs (lines 219-226)
WuppieFuzz/src/state.rs (lines 239-246)
WuppieFuzz/src/state.rs (lines 275-282)

📚 Remaining technical debt

2 refactoring candidates didn't get better or worse, but are still present in the code you touched.

View this system in Sigrid** to explore your technical debt

⭐️ Sigrid ratings

System property System on 2024-11-07 Before changes New/changed code
Volume 5.4 N/A N/A
Duplication 4.0 4.4 4.4
Unit Size 2.1 1.2 1.2
Unit Complexity 2.9 5.5 5.5
Unit Interfacing 2.0 5.5 5.5
Module Coupling 3.3 5.5 5.5
Component Independence 5.4 N/A N/A
Component Entanglement N/A N/A N/A
Maintainability 3.6 4.4 4.4

Did you find this feedback helpful?

We would like to know your thoughts to make Sigrid better.
Your username will remain confidential throughout the process.


View this system in Sigrid

src/fuzzer.rs Outdated Show resolved Hide resolved
@ThomasTNO ThomasTNO merged commit d38889d into main Nov 28, 2024
6 checks passed
@ThomasTNO ThomasTNO deleted the temp_fix_crtl_c branch November 28, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stopping not implemented
2 participants