Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added OPTIONS and CONNECT methods #32

Merged
merged 4 commits into from
Oct 30, 2024
Merged

added OPTIONS and CONNECT methods #32

merged 4 commits into from
Oct 30, 2024

Conversation

ringogroenewegen
Copy link
Contributor

Two HTTP methods were missing: Options and Connect. These are now added to prevent the fuzzer from crashing when encountering these in an OpenAPI spec

Copy link

github-actions bot commented Oct 23, 2024

Sigrid maintainability feedback

✅ You wrote maintainable code and achieved your Sigrid objective of 3.5 stars

Sigrid compared your code against the baseline of 2024-10-18.

👍 What went well?

You fixed or improved 0 refactoring candidates.

👎 What could be better?

Unfortunately, 1 refactoring candidates were introduced or got worse.

Risk System property Location
🔴 Duplication
(Introduced)
WuppieFuzz/src/input/method.rs (lines 148-154)
WuppieFuzz/src/input/method.rs (lines 159-165)

📚 Remaining technical debt

0 refactoring candidates didn't get better or worse, but are still present in the code you touched.

Sigrid ratings

System property System on 2024-10-18 Before changes New/changed code
Volume 5.4 N/A N/A
Duplication 3.9 3.4 3.6
Unit Size 2.1 5.5 5.5
Unit Complexity 2.9 5.5 5.5
Unit Interfacing 2.0 5.5 5.5
Module Coupling 3.3 N/A N/A
Component Independence 5.4 N/A N/A
Component Entanglement N/A N/A N/A
Maintainability 3.6 4.9 5.0

View this system in Sigrid


Did you find this feedback helpful?

We would like to know your thoughts to make Sigrid better.
Your username will remain confidential throughout the process.

@ThomasTNO
Copy link
Contributor

Looks good, can you add a changelog entry in CHANGELOG.md?

@ringogroenewegen
Copy link
Contributor Author

Looks good, can you add a changelog entry in CHANGELOG.md?

Done!

Add pull request link.
@ThomasTNO ThomasTNO merged commit 6b940ae into main Oct 30, 2024
3 checks passed
@ThomasTNO ThomasTNO deleted the all_http_methods branch November 5, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants