-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve rule to handle more than one test class matching impl class #920
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for taking care of this so quickly 😃 Looks good to me, just a couple of minor nitpicks you could look into.
archunit/src/main/java/com/tngtech/archunit/library/GeneralCodingRules.java
Show resolved
Hide resolved
archunit/src/main/java/com/tngtech/archunit/library/GeneralCodingRules.java
Outdated
Show resolved
Hide resolved
archunit/src/test/java/com/tngtech/archunit/library/GeneralCodingRulesTest.java
Outdated
Show resolved
Hide resolved
archunit/src/test/java/com/tngtech/archunit/library/GeneralCodingRulesTest.java
Outdated
Show resolved
Hide resolved
archunit/src/test/java/com/tngtech/archunit/library/GeneralCodingRulesTest.java
Outdated
Show resolved
Hide resolved
Ah, one more thing, could you also make sure that each commit message header is not longer than 70 chars? So GitHub doesn't break it over? And it would be cool, if you could put the details from the PR description into the commit message as details as well. Because I want to keep a clean Git history that is self-explanatory and does not depend on GitHub as a platform for further context. |
7ec7d8e
to
2ab4386
Compare
Thanks for explaining point of view. I adjusted the PR according to comments 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good now, thanks a lot!! 😃
This will improve the existing rule to test that test classes reside in the same package as their implementation. In particular the rule 1. Should not fail if there are multiple test classes with the same simple name as long as one test class resides in the correct package 2. Should fail if none of multiple test classes matching by name with implementation class are in correct package Signed-off-by: Marcin Słowiak <[email protected]>
2ab4386
to
b8b0fdc
Compare
This will improve the existing rule to test that test classes reside in the same package as their implementation. In particular the rule
Resolves #918