Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding log statements around archUnit property file #197

Conversation

vincent-fuchs
Copy link
Contributor

adding log statements to indicate whether archUnit property file is found or not : when adding a property file but nothing happens, it's useful to easily see in the logs if the file is picked up or not.

Having a simple log statement can also be very helpful to somebody new to a project using archUnit, but not getting the expected behavior : it will indicate clearly that a property file has been picked up

@codecholeric
Copy link
Collaborator

codecholeric commented Jul 19, 2019

Thanks a lot! Yes, I agree that can save some time 😉
If I look at the code, I wonder if it wouldn't make sense to also log a warning for an occurring IOException? I don't think it was a good idea back then to just secretly swallow it.
In any case, could you check out https://github.com/TNG/ArchUnit/blob/master/CONTRIBUTING.md?
In particular

  • please sign the commits according to the DCO (easiest with one commit: git commit -s --amend)
  • please format the code with the provided formatter (I hope you're using either Eclipse or IntelliJ 😉)

Also I think all logging statements within the code base start with an upper case letter.
Thank you!!

@vincent-fuchs vincent-fuchs force-pushed the addingLogStatementsForPropertyFileLoading branch from 449c793 to 88607d3 Compare July 21, 2019 13:07
@vincent-fuchs
Copy link
Contributor Author

sorry for the delay - I fixed my commit and force-pushed. I also added a warn log statement as you suggested.

vincent-fuchs and others added 3 commits July 21, 2019 18:40
…xception while reading properties file

Signed-off-by: Vincent FUCHS <[email protected]>
…ties has resolved to in the logging statement

Signed-off-by: Peter Gafert <[email protected]>
@codecholeric codecholeric force-pushed the addingLogStatementsForPropertyFileLoading branch from 1f0b741 to b8d9594 Compare July 21, 2019 16:42
@codecholeric
Copy link
Collaborator

Thanks 😃 Now that I looked at it again I thought it might be useful to see the full resolved URL of archunit.properties. So I've rebased against upstream master and added a little review commit to resolve the URL separately and then print that within the log statement.

@codecholeric codecholeric merged commit 1d74f31 into TNG:master Jul 21, 2019
codecholeric added a commit that referenced this pull request Feb 21, 2021
…ropertyFileLoading

adding log statements around archUnit property file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants