Consider Jakarta EE9 injection annotations for general coding rule #1286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Manfred Hanke <[email protected]>
The condition `BE_ANNOTATED_WITH_AN_INJECTION_ANNOTATION` and the rule `NO_CLASSES_SHOULD_USE_FIELD_INJECTION` previously considered the `javax.inject.Inject` and `javax.annotation.Resource` annotations, but not their jakarta variants (`jakarta.inject.Inject` and `jakarta.annotation.Resource`). Resolves: #1285 Signed-off-by: Manfred Hanke <[email protected]>
codecholeric
force-pushed
the
consider-jakarta-annotations
branch
from
56f8ecb to
1d1a990
Compare
codecholeric
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The condition
BE_ANNOTATED_WITH_AN_INJECTION_ANNOTATIONand the ruleNO_CLASSES_SHOULD_USE_FIELD_INJECTIONpreviously considered thejavax.inject.Injectandjavax.annotation.Resourceannotations, but not their jakarta variants (jakarta.inject.Injectandjakarta.annotation.Resource).Resolves: #1285