Eliminate redundant line number #1220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hankem
force-pushed
the
eliminate-redundant-lineNumber
branch
from
2a90db7 to
1df5bf0
Compare
Signed-off-by: Manfred Hanke <[email protected]>
when that information is already stored in the sourceCodeLocation object Signed-off-by: Manfred Hanke <[email protected]>
At the moment the line number is passed to the `Dependency`, then it constructs a `SourceCodeLocation` from the `originClass` and the `lineNumber`. In all cases we have a `SourceCodeLocation` outside already though. And the `SourceCodeLocation` constructed in the constructor of `Dependency` will just create an equivalent `SourceCodeLocation` to what we already have when calling the constructor. We can thus just pass on the `SourceCodeLocation` from the outside. Signed-off-by: Peter Gafert <[email protected]>
codecholeric
force-pushed
the
eliminate-redundant-lineNumber
branch
from
1df5bf0 to
ef726a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some classes store a
int lineNumberfield next to aSourceCodeLocation.This PR eliminates the redundancy, which suggests more degrees of freedom than there actually are.