remove unnecessary final on variables or parameters

Signed-off-by: Manfred Hanke <[email protected]>
TNG · Nov 21, 2022 · 736ffb6 · 736ffb6
1 parent db567e6
commit 736ffb6
Show file tree

Hide file tree

Showing 153 changed files with 397 additions and 402 deletions.
diff --git a/...ple-junit4/src/test/java/com/tngtech/archunit/exampletest/junit4/SlicesIsolationTest.java b/...ple-junit4/src/test/java/com/tngtech/archunit/exampletest/junit4/SlicesIsolationTest.java
@@ -38,7 +38,7 @@ public class SlicesIsolationTest {
                     .ignoreDependency(UseCaseOneTwoController.class, UseCaseTwoController.class)
                     .ignoreDependency(nameMatching(".*controller\\.three.*"), alwaysTrue());
 
-    private static DescribedPredicate<Slice> containDescription(final String descriptionPart) {
+    private static DescribedPredicate<Slice> containDescription(String descriptionPart) {
         return new DescribedPredicate<Slice>("contain description '%s'", descriptionPart) {
             @Override
             public boolean test(Slice input) {

diff --git a/...ple-junit5/src/test/java/com/tngtech/archunit/exampletest/junit5/SlicesIsolationTest.java b/...ple-junit5/src/test/java/com/tngtech/archunit/exampletest/junit5/SlicesIsolationTest.java
@@ -35,7 +35,7 @@ public class SlicesIsolationTest {
                     .ignoreDependency(UseCaseOneTwoController.class, UseCaseTwoController.class)
                     .ignoreDependency(nameMatching(".*controller\\.three.*"), alwaysTrue());
 
-    private static DescribedPredicate<Slice> containDescription(final String descriptionPart) {
+    private static DescribedPredicate<Slice> containDescription(String descriptionPart) {
         return new DescribedPredicate<Slice>("contain description '%s'", descriptionPart) {
             @Override
             public boolean test(Slice input) {

diff --git a/...va/com/tngtech/archunit/example/layers/persistence/first/dao/domain/PersistentObject.java b/...va/com/tngtech/archunit/example/layers/persistence/first/dao/domain/PersistentObject.java
@@ -31,7 +31,7 @@ public boolean equals(Object obj) {
         if (obj == null || getClass() != obj.getClass()) {
             return false;
         }
-        final PersistentObject other = (PersistentObject) obj;
+        PersistentObject other = (PersistentObject) obj;
         return Objects.equals(this.id, other.id);
     }
 }
diff --git a/.../tngtech/archunit/example/layers/persistence/second/dao/domain/OtherPersistentObject.java b/.../tngtech/archunit/example/layers/persistence/second/dao/domain/OtherPersistentObject.java
@@ -38,7 +38,7 @@ public boolean equals(Object obj) {
         if (obj == null || getClass() != obj.getClass()) {
             return false;
         }
-        final OtherPersistentObject other = (OtherPersistentObject) obj;
+        OtherPersistentObject other = (OtherPersistentObject) obj;
         return Objects.equals(this.id, other.id);
     }
 }
diff --git a/...ple/example-plain/src/test/java/com/tngtech/archunit/exampletest/SlicesIsolationTest.java b/...ple/example-plain/src/test/java/com/tngtech/archunit/exampletest/SlicesIsolationTest.java
@@ -43,7 +43,7 @@ public void controllers_should_only_use_their_own_slice_with_custom_ignore() {
                 .check(classes);
     }
 
-    private static DescribedPredicate<Slice> containDescription(final String descriptionPart) {
+    private static DescribedPredicate<Slice> containDescription(String descriptionPart) {
         return new DescribedPredicate<Slice>("contain description '%s'", descriptionPart) {
             @Override
             public boolean test(Slice input) {

diff --git a/...plain/src/test/java/com/tngtech/archunit/exampletest/extension/NewConfigurationEvent.java b/...plain/src/test/java/com/tngtech/archunit/exampletest/extension/NewConfigurationEvent.java
@@ -35,7 +35,7 @@ public boolean equals(Object obj) {
         if (obj == null || getClass() != obj.getClass()) {
             return false;
         }
-        final NewConfigurationEvent other = (NewConfigurationEvent) obj;
+        NewConfigurationEvent other = (NewConfigurationEvent) obj;
         return Objects.equals(this.properties, other.properties);
     }
 

diff --git a/archunit-integration-test/src/test/java/com/tngtech/archunit/ArchUnitArchitectureTest.java b/archunit-integration-test/src/test/java/com/tngtech/archunit/ArchUnitArchitectureTest.java
@@ -83,11 +83,11 @@ private static DescribedPredicate<JavaCall<?>> typeIsIllegallyResolvedViaReflect
         return classIsResolvedViaReflection().and(not(explicitlyAllowedUsage));
     }
 
-    private static DescribedPredicate<JavaAccess<?>> contextIsAnnotatedWith(final Class<? extends Annotation> annotationType) {
+    private static DescribedPredicate<JavaAccess<?>> contextIsAnnotatedWith(Class<? extends Annotation> annotationType) {
         return origin(With.owner(withAnnotation(annotationType)));
     }
 
-    private static DescribedPredicate<JavaClass> withAnnotation(final Class<? extends Annotation> annotationType) {
+    private static DescribedPredicate<JavaClass> withAnnotation(Class<? extends Annotation> annotationType) {
         return new DescribedPredicate<JavaClass>("annotated with @" + annotationType.getName()) {
             @Override
             public boolean test(JavaClass input) {

diff --git a/...egration-test/src/test/java/com/tngtech/archunit/integration/ExamplesIntegrationTest.java b/...egration-test/src/test/java/com/tngtech/archunit/integration/ExamplesIntegrationTest.java
@@ -1263,8 +1263,8 @@ Stream<DynamicTest> RestrictNumberOfClassesWithACertainPropertyTest() {
 
     }
 
-    private static MessageAssertionChain.Link classesContaining(final Class<?>... classes) {
-        final String expectedLine = String.format("there is/are %d element(s) in %s", classes.length, formatNamesOf(classes));
+    private static MessageAssertionChain.Link classesContaining(Class<?>... classes) {
+        String expectedLine = String.format("there is/are %d element(s) in %s", classes.length, formatNamesOf(classes));
         return new MessageAssertionChain.Link() {
             @Override
             public Result filterMatching(List<String> lines) {

diff --git a/...gration-test/src/test/java/com/tngtech/archunit/integration/ExtensionIntegrationTest.java b/...gration-test/src/test/java/com/tngtech/archunit/integration/ExtensionIntegrationTest.java
@@ -65,7 +65,7 @@ void evaluation_results_are_only_dispatched_to_enabled_extensions() {
         assertThat(ExampleExtension.getEvaluatedRuleEvents()).isEmpty();
     }
 
-    private static Condition<Object> containingEntry(final String propKey, final String propValue) {
+    private static Condition<Object> containingEntry(String propKey, String propValue) {
         return new Condition<Object>(String.format("containing entry {%s=%s}", propKey, propValue)) {
             @Override
             public boolean matches(Object value) {

diff --git a/...nit-integration-test/src/test/java/com/tngtech/archunit/testutils/CyclicErrorMatcher.java b/...nit-integration-test/src/test/java/com/tngtech/archunit/testutils/CyclicErrorMatcher.java
@@ -58,7 +58,7 @@ public CyclicErrorMatcher by(ExpectedRelation dependency) {
 
     @Override
     public MessageAssertionChain.Link.Result filterMatching(List<String> lines) {
-        final Result.Builder builder = new Result.Builder()
+        Result.Builder builder = new Result.Builder()
                 .containsText(cycleText());
 
         for (String sliceName : details.asMap().keySet()) {

diff --git a/...unit-integration-test/src/test/java/com/tngtech/archunit/testutils/HandlingAssertion.java b/...unit-integration-test/src/test/java/com/tngtech/archunit/testutils/HandlingAssertion.java
@@ -80,39 +80,39 @@ Result evaluate(EvaluationResult evaluationResult) {
 
     private Set<String> evaluateFieldAccesses(EvaluationResult result) {
         Set<String> errorMessages = new HashSet<>();
-        final Set<ExpectedRelation> left = new HashSet<>(this.expectedFieldAccesses);
+        Set<ExpectedRelation> left = new HashSet<>(this.expectedFieldAccesses);
         result.handleViolations((Collection<JavaFieldAccess> violatingObjects, String message) ->
                 errorMessages.addAll(removeExpectedAccesses(violatingObjects, left)));
         return union(errorMessages, errorMessagesFrom(left));
     }
 
     private Set<String> evaluateMethodCalls(EvaluationResult result) {
         Set<String> errorMessages = new HashSet<>();
-        final Set<ExpectedRelation> left = new HashSet<>(expectedMethodCalls);
+        Set<ExpectedRelation> left = new HashSet<>(expectedMethodCalls);
         result.handleViolations((Collection<JavaMethodCall> violatingObjects, String message) ->
                 errorMessages.addAll(removeExpectedAccesses(violatingObjects, left)));
         return union(errorMessages, errorMessagesFrom(left));
     }
 
     private Set<String> evaluateConstructorCalls(EvaluationResult result) {
         Set<String> errorMessages = new HashSet<>();
-        final Set<ExpectedRelation> left = new HashSet<>(expectedConstructorCalls);
+        Set<ExpectedRelation> left = new HashSet<>(expectedConstructorCalls);
         result.handleViolations((Collection<JavaConstructorCall> violatingObjects, String message) ->
                 errorMessages.addAll(removeExpectedAccesses(violatingObjects, left)));
         return union(errorMessages, errorMessagesFrom(left));
     }
 
     private Set<String> evaluateCalls(EvaluationResult result) {
         Set<String> errorMessages = new HashSet<>();
-        final Set<ExpectedRelation> left = new HashSet<>(Sets.union(expectedConstructorCalls, expectedMethodCalls));
+        Set<ExpectedRelation> left = new HashSet<>(Sets.union(expectedConstructorCalls, expectedMethodCalls));
         result.handleViolations((Collection<JavaCall<?>> violatingObjects, String message) ->
                 errorMessages.addAll(removeExpectedAccesses(violatingObjects, left)));
         return union(errorMessages, errorMessagesFrom(left));
     }
 
     private Set<String> evaluateAccesses(EvaluationResult result) {
         Set<String> errorMessages = new HashSet<>();
-        final Set<ExpectedRelation> left = new HashSet<ExpectedRelation>() {
+        Set<ExpectedRelation> left = new HashSet<ExpectedRelation>() {
             {
                 addAll(expectedConstructorCalls);
                 addAll(expectedMethodCalls);
@@ -126,7 +126,7 @@ private Set<String> evaluateAccesses(EvaluationResult result) {
 
     private Set<String> evaluateDependencies(EvaluationResult result) {
         Set<String> errorMessages = new HashSet<>();
-        final Set<ExpectedRelation> left = new HashSet<>(expectedDependencies);
+        Set<ExpectedRelation> left = new HashSet<>(expectedDependencies);
         result.handleViolations((Collection<Dependency> violatingObjects, String message) ->
                 errorMessages.addAll(removeExpectedAccesses(violatingObjects, left)));
         return union(errorMessages, errorMessagesFrom(left));

diff --git a/...-integration-test/src/test/java/com/tngtech/archunit/testutils/MessageAssertionChain.java b/...-integration-test/src/test/java/com/tngtech/archunit/testutils/MessageAssertionChain.java
@@ -38,8 +38,8 @@ public String toString() {
         return links.stream().map(Link::getDescription).collect(joining(lineSeparator()));
     }
 
-    static Link matchesLine(final String pattern) {
-        final Pattern p = Pattern.compile(pattern);
+    static Link matchesLine(String pattern) {
+        Pattern p = Pattern.compile(pattern);
         return new Link() {
             @Override
             public Result filterMatching(List<String> lines) {
@@ -61,7 +61,7 @@ public String getDescription() {
     }
 
     static Link containsLine(String text, Object... args) {
-        final String expectedLine = String.format(text, args);
+        String expectedLine = String.format(text, args);
         return new Link() {
             @Override
             public Result filterMatching(List<String> lines) {
@@ -79,7 +79,7 @@ public String getDescription() {
 
     static Link containsText(String text, Object... args) {
         String expectedText = String.format(text, args);
-        final List<String> expectedLines = Splitter.on(lineSeparator()).splitToList(expectedText);
+        List<String> expectedLines = Splitter.on(lineSeparator()).splitToList(expectedText);
         return new Link() {
             @Override
             public Result filterMatching(List<String> lines) {
@@ -115,10 +115,10 @@ private static String describeLines(List<String> lines) {
         return "Lines were >>>>>>>>" + lineSeparator() + Joiner.on(lineSeparator()).join(lines) + lineSeparator() + "<<<<<<<<";
     }
 
-    static Link containsConsecutiveLines(final List<String> expectedLines) {
+    static Link containsConsecutiveLines(List<String> expectedLines) {
         checkArgument(!expectedLines.isEmpty(), "Asserting zero consecutive lines makes no sense");
-        final String linesDescription = Joiner.on(lineSeparator()).join(expectedLines);
-        final String description = "Message contains consecutive lines " + lineSeparator() + linesDescription;
+        String linesDescription = Joiner.on(lineSeparator()).join(expectedLines);
+        String description = "Message contains consecutive lines " + lineSeparator() + linesDescription;
 
         return new Link() {
             @Override

diff --git a/...unit/junit4/src/main/java/com/tngtech/archunit/junit/internal/ArchUnitRunnerInternal.java b/...unit/junit4/src/main/java/com/tngtech/archunit/junit/internal/ArchUnitRunnerInternal.java
@@ -64,7 +64,7 @@ private static AnalyzeClasses checkAnnotation(Class<?> testClass) {
 
     @Override
     public Statement classBlock(RunNotifier notifier) {
-        final Statement statement = super.classBlock(notifier);
+        Statement statement = super.classBlock(notifier);
         return new Statement() {
             @Override
             public void evaluate() throws Throwable {

diff --git a/...it4/src/test/java/com/tngtech/archunit/junit/internal/ArchUnitRunnerRunsRuleSetsTest.java b/...it4/src/test/java/com/tngtech/archunit/junit/internal/ArchUnitRunnerRunsRuleSetsTest.java
@@ -201,7 +201,7 @@ private Runnable verifyTestRan() {
     }
 
     // extractingResultOf(..) only looks for public methods
-    private Extractor<Object, Object> resultOf(final String methodName) {
+    private Extractor<Object, Object> resultOf(String methodName) {
         return input -> {
             Collection<Method> candidates = getAllMethods(input.getClass(), method -> method.getName().equals(methodName));
             checkState(!candidates.isEmpty(),

diff --git a/.../junit5/engine-api/src/main/java/com/tngtech/archunit/junit/engine_api/FieldSelector.java b/.../junit5/engine-api/src/main/java/com/tngtech/archunit/junit/engine_api/FieldSelector.java
@@ -59,7 +59,7 @@ public boolean equals(Object obj) {
         if (obj == null || getClass() != obj.getClass()) {
             return false;
         }
-        final FieldSelector other = (FieldSelector) obj;
+        FieldSelector other = (FieldSelector) obj;
         return Objects.equals(this.clazz, other.clazz)
                 && Objects.equals(this.field, other.field);
     }

diff --git a/...it/junit5/engine-api/src/main/java/com/tngtech/archunit/junit/engine_api/FieldSource.java b/...it/junit5/engine-api/src/main/java/com/tngtech/archunit/junit/engine_api/FieldSource.java
@@ -62,7 +62,7 @@ public boolean equals(Object obj) {
 		if (obj == null || getClass() != obj.getClass()) {
 			return false;
 		}
-        final FieldSource other = (FieldSource) obj;
+        FieldSource other = (FieldSource) obj;
         return Objects.equals(this.javaClass, other.javaClass)
                 && Objects.equals(this.fieldName, other.fieldName);
     }

diff --git a/archunit-junit/src/main/java/com/tngtech/archunit/junit/internal/ClassCache.java b/archunit-junit/src/main/java/com/tngtech/archunit/junit/internal/ClassCache.java
@@ -149,7 +149,7 @@ public boolean equals(Object obj) {
             if (obj == null || getClass() != obj.getClass()) {
                 return false;
             }
-            final LocationsKey other = (LocationsKey) obj;
+            LocationsKey other = (LocationsKey) obj;
             return Objects.equals(this.importOptionTypes, other.importOptionTypes)
                     && Objects.equals(this.locations, other.locations);
         }

diff --git a/archunit-junit/src/main/java/com/tngtech/archunit/junit/internal/ReflectionUtils.java b/archunit-junit/src/main/java/com/tngtech/archunit/junit/internal/ReflectionUtils.java
@@ -121,7 +121,7 @@ private static <T extends Throwable> void rethrowUnchecked(Throwable throwable)
         throw (T) throwable;
     }
 
-    static Predicate<AnnotatedElement> withAnnotation(final Class<? extends Annotation> annotationType) {
+    static Predicate<AnnotatedElement> withAnnotation(Class<? extends Annotation> annotationType) {
         return input -> input.isAnnotationPresent(annotationType);
     }
 }
diff --git a/...it-junit/src/test/java/com/tngtech/archunit/junit/internal/ClassCacheConcurrencyTest.java b/...it-junit/src/test/java/com/tngtech/archunit/junit/internal/ClassCacheConcurrencyTest.java
@@ -67,7 +67,7 @@ public void concurrent_access() throws Exception {
         verifyNoMoreInteractions(classFileImporter);
     }
 
-    private Runnable repeatGetClassesToAnalyze(final int times) {
+    private Runnable repeatGetClassesToAnalyze(int times) {
         return () -> {
             for (int j = 0; j < times; j++) {
                 cache.getClassesToAnalyzeFor(TEST_CLASSES.get(j % TEST_CLASSES.size()),

diff --git a/archunit-junit/src/test/java/com/tngtech/archunit/junit/internal/ClassCacheTest.java b/archunit-junit/src/test/java/com/tngtech/archunit/junit/internal/ClassCacheTest.java
@@ -246,7 +246,7 @@ private void verifyNumberOfImports(int number) {
         verifyNoMoreInteractions(cacheClassFileImporter);
     }
 
-    private static Condition<Iterable<? extends Location>> locationContaining(final String part) {
+    private static Condition<Iterable<? extends Location>> locationContaining(String part) {
         return new Condition<Iterable<? extends Location>>() {
             @Override
             public boolean matches(Iterable<? extends Location> locations) {

diff --git a/archunit-junit/src/test/java/com/tngtech/archunit/junit/internal/ReflectionUtilsTest.java b/archunit-junit/src/test/java/com/tngtech/archunit/junit/internal/ReflectionUtilsTest.java
@@ -62,7 +62,7 @@ public void getAllFields_of_interface() {
                         field(OtherInterface.class, "OTHER_CONSTANT"));
     }
 
-    private Predicate<Member> named(final String name) {
+    private Predicate<Member> named(String name) {
         return input -> input.getName().equals(name);
     }
 

diff --git a/archunit/src/main/java/com/tngtech/archunit/base/ChainableFunction.java b/archunit/src/main/java/com/tngtech/archunit/base/ChainableFunction.java
@@ -23,7 +23,7 @@
 
 @PublicAPI(usage = INHERITANCE)
 public abstract class ChainableFunction<F, T> implements Function<F, T> {
-    public <E> ChainableFunction<E, T> after(final Function<? super E, ? extends F> function) {
+    public <E> ChainableFunction<E, T> after(Function<? super E, ? extends F> function) {
         return new ChainableFunction<E, T>() {
             @Override
             public T apply(E input) {
@@ -32,7 +32,7 @@ public T apply(E input) {
         };
     }
 
-    public <U> ChainableFunction<F, U> then(final Function<? super T, ? extends U> function) {
+    public <U> ChainableFunction<F, U> then(Function<? super T, ? extends U> function) {
         return new ChainableFunction<F, U>() {
             @Override
             public U apply(F input) {

diff --git a/archunit/src/main/java/com/tngtech/archunit/base/DescribedIterable.java b/archunit/src/main/java/com/tngtech/archunit/base/DescribedIterable.java
@@ -30,7 +30,7 @@ private From() {
         }
 
         @PublicAPI(usage = ACCESS)
-        public static <T> DescribedIterable<T> iterable(final Iterable<T> iterable, final String description) {
+        public static <T> DescribedIterable<T> iterable(Iterable<T> iterable, String description) {
             return new DescribedIterable<T>() {
                 @Override
                 public String getDescription() {