Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allo to scan large files #5

Merged
merged 3 commits into from
Jan 12, 2024

Conversation

Edmondi-Kacaj
Copy link
Member

contentReader.getContentString() is not suitable for large files and cannot be handled by the JVM and Exceptions are thrown. As a consequence, the file upload is rejected in this case.
so this pull request will fix this problem and we will use contentReader.getContentInputStream() instead of contentReader.getContentString(), to handle larger files

…er.getContentString(), to handle larger files
Copy link
Collaborator

@mirjan-hoffmann mirjan-hoffmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @Edmondi-Kacaj

Can you please assure that the input stream is closed after the scan

@Edmondi-Kacaj
Copy link
Member Author

thanks @Edmondi-Kacaj

Can you please assure that the input stream is closed after the scan

I already did that, thanks for detecting that

@mirjan-hoffmann mirjan-hoffmann merged commit 0436638 into TIBHannover:master Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants