Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print proper error if trigger doesn't exist #109

Merged
merged 1 commit into from
Jun 1, 2018
Merged

Conversation

retgits
Copy link
Contributor

@retgits retgits commented Jun 1, 2018

What kind of change does this PR introduce? (check one with "x")

[X] Bugfix
[] Feature
[] Code style update (formatting, local variables)
[] Refactoring (no functional changes, no api changes)
[] Other... Please describe:

Fixes: TIBCOSoftware/flogo#286

What is the current behavior?

If the trigger id passed in doesn't exist an error is thrown

runtime.main_main·f: relocation target main.main not defined
runtime.main_main·f: undefined: "main.main"
FATAL: command "build" failed: exit status 2

What is the new behavior?

If the trigger id passed in doesn't exist a friendly error is shown

$ flogo build -e -shim my_lambda_trigger
Shim: my_lambda_trigger

Can't locate trigger with id [my_lambda_trigger] in flogo.json
Please check if you have specified the correct trigger id

@retgits retgits requested a review from mellistibco June 1, 2018 17:52
@retgits retgits merged commit 1855abb into master Jun 1, 2018
@retgits retgits deleted the check-shim-exists branch June 1, 2018 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants