WIP: Provisioning service #1678
Draft
+1,177
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pizkaz
force-pushed
the
1636-provisioning-api
branch
7 times, most recently
from
da2f5df to
980177a
Compare
pizkaz
force-pushed
the
1636-provisioning-api
branch
from
980177a to
a86d409
Compare
SamuelWei
reviewed
Dec 19, 2024
| protected array $expectedProperties = [ | ||
| 'name' => 'required|string', | ||
| 'description' => 'required|string', | ||
| 'servers' => 'required|list', |
There was a problem hiding this comment.
Suggested change
| 'servers' => 'required|list', | |
| 'servers' => 'required|list|distinct|exists:servers,name', |
SamuelWei
reviewed
Dec 19, 2024
| 'name' => 'required|string', | ||
| 'description' => 'required|string', | ||
| 'color' => 'required|string', | ||
| 'server_pool' => 'required|string', |
There was a problem hiding this comment.
Suggested change
| 'server_pool' => 'required|string', | |
| 'server_pool' => 'required|exists: server_pools,name', |
…of server names at DB level
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1636
Type (Highlight the corresponding type)
Checklist
Changes
ProvisioningServiceproviding an API for CRUD operations on models.app:provisioncommand consumings a JSON file and using theProvisioningServiceto delete existing (if so desired) models and adding new ones according to JSON data.Other information