Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error handling in room stats and attendance #1600

Draft
wants to merge 16 commits into
base: develop
Choose a base branch
from

Conversation

SamuelWei
Copy link
Collaborator

@SamuelWei SamuelWei commented Nov 21, 2024

Fixes #1535

Type (Highlight the corresponding type)

  • Bugfix
  • Feature
  • Documentation
  • Refactoring (e.g. Style updates, Test implementation, etc.): Error Handling
  • Other (please describe):

Checklist

  • Code updated to current develop branch head
  • Passes CI checks
  • Is a part of an issue
  • Tests added for the bugfix or newly implemented feature, describe below why if not
  • Changelog is updated
  • Documentation of code and features exists

Changes

  • Improve error handling in room statistics dialog
  • Improve error handling in room attendance dialog
  • Add happo.io for visual testing

@SamuelWei SamuelWei linked an issue Nov 21, 2024 that may be closed by this pull request
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 61.29032% with 12 lines in your changes missing coverage. Please review.

Project coverage is 80.95%. Comparing base (b030a62) to head (98e361e).

Files with missing lines Patch % Lines
...s/js/components/RoomTabHistoryAttendanceButton.vue 55.55% 8 Missing ⚠️
...es/js/components/RoomTabHistoryStatisticButton.vue 66.66% 4 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #1600      +/-   ##
=============================================
- Coverage      81.01%   80.95%   -0.07%     
  Complexity      1340     1340              
=============================================
  Files            361      361              
  Lines           9225     9255      +30     
  Branches         853      861       +8     
=============================================
+ Hits            7474     7492      +18     
- Misses          1751     1763      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Nov 21, 2024

PILOS    Run #1525

Run Properties:  status check passed Passed #1525  •  git commit 98e361ead9: Improve error handling in room stats and attendance
Project PILOS
Branch Review 1535-improve-error-handling-in-room-history-components
Run status status check passed Passed #1525
Run duration 05m 01s
Commit git commit 98e361ead9: Improve error handling in room stats and attendance
Committer Samuel Weirich
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 238
View all changes introduced in this branch ↗︎

@SamuelWei SamuelWei force-pushed the 1535-improve-error-handling-in-room-history-components branch from 89eb069 to a0b8071 Compare December 19, 2024 15:54
@SamuelWei SamuelWei force-pushed the 1535-improve-error-handling-in-room-history-components branch from 36d3017 to 1d56b83 Compare December 20, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve error handling in room history components
1 participant