Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplement frontend tests with cypress #1483

Merged
merged 147 commits into from
Oct 16, 2024

Conversation

Sabr1n4W
Copy link
Contributor

@Sabr1n4W Sabr1n4W commented Oct 16, 2024

Partially implements #1150
Implements #721
Implements #722

Type (Highlight the corresponding type)

  • Bugfix
  • Feature
  • Documentation
  • Refactoring (e.g. Style updates, Test implementation, etc.)
  • Other (please describe):

Checklist

  • Code updated to current develop branch head
  • Passes CI checks
  • Is a part of an issue
  • Tests added for the bugfix or newly implemented feature, describe below why if not
  • Changelog is updated
  • Documentation of code and features exists

Changes

  • Add frontend tests for Login, Logout, Locales
  • Add frontend tests for Room Index page
  • Add frontend tests for Room page
  • Add frontend tests for Room Members Tab
  • Add frontend tests for Room Settings Tab
  • Add frontend tests for Room Files Tab
  • Add frontend tests for User Profile
  • Add frontend tests for Room Description

Sabr1n4W and others added 30 commits June 14, 2024 15:51
…alent-frontend-test-scope-in-cypress

# Conflicts:
#	tests/Frontend/e2e/GeneralApplication.cy.js
#	tests/Frontend/e2e/Login.cy.js
#	tests/Frontend/e2e/RoomsIndex.cy.js
#	tests/Frontend/e2e/RoomsViewGeneral.cy.js
#	tests/Frontend/support/commands.js
…alent-frontend-test-scope-in-cypress

# Conflicts:
#	tests/Frontend/e2e/GeneralApplication.cy.js
#	tests/Frontend/e2e/Login.cy.js
#	tests/Frontend/e2e/RoomsIndex.cy.js
#	tests/Frontend/e2e/RoomsViewGeneral.cy.js
#	tests/Frontend/support/commands.js
SamuelWei and others added 23 commits October 7, 2024 18:31
…alent-frontend-test-scope-in-cypress

# Conflicts:
#	CHANGELOG.md
…alent-frontend-test-scope-in-cypress

# Conflicts:
#	.github/workflows/ci.yml
…alent-frontend-test-scope-in-cypress

# Conflicts:
#	package-lock.json
#	package.json
…alent-frontend-test-scope-in-cypress

# Conflicts:
#	CHANGELOG.md
…alent-frontend-test-scope-in-cypress

# Conflicts:
#	CHANGELOG.md
#	resources/js/components/LocaleSelect.vue
#	resources/js/components/RoleSelect.vue
#	resources/js/components/RoomTabMembersAddSingleModal.vue
#	resources/js/components/RoomTabMembersBulkEditButton.vue
#	resources/js/components/RoomTabMembersBulkImportList.vue
#	resources/js/components/RoomTabMembersBulkImportModal.vue
#	resources/js/components/RoomTabMembersEditButton.vue
#	resources/js/components/RoomTransferOwnershipButton.vue
#	resources/js/components/UserTabProfile.vue
#	resources/js/components/UserTabSecurityRolesAndPermissionsSection.vue
#	resources/js/i18n.js
@Sabr1n4W Sabr1n4W self-assigned this Oct 16, 2024
@SamuelWei SamuelWei self-requested a review October 16, 2024 14:09
Copy link
Collaborator

@SamuelWei SamuelWei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Great work!

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.05%. Comparing base (08ba3fc) to head (aac061d).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff               @@
##             develop    #1483       +/-   ##
==============================================
- Coverage      95.35%   76.05%   -19.30%     
  Complexity      1321     1321               
==============================================
  Files            202      359      +157     
  Lines           4582     8765     +4183     
  Branches           0      670      +670     
==============================================
+ Hits            4369     6666     +2297     
- Misses           213     2099     +1886     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Oct 16, 2024

PILOS    Run #862

Run Properties:  status check passed Passed #862  •  git commit d41238fdbb: Reimplement frontend tests with cypress (#1483)
Project PILOS
Run status status check passed Passed #862
Run duration 03m 44s
Commit git commit d41238fdbb: Reimplement frontend tests with cypress (#1483)
Committer Sabrina Wüst
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 165

@Sabr1n4W Sabr1n4W merged commit d41238f into develop Oct 16, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants