-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reimplement frontend tests with cypress #1483
Merged
Sabr1n4W
merged 147 commits into
develop
from
1150-equivalent-frontend-test-scope-in-cypress
Oct 16, 2024
Merged
Reimplement frontend tests with cypress #1483
Sabr1n4W
merged 147 commits into
develop
from
1150-equivalent-frontend-test-scope-in-cypress
Oct 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alent-frontend-test-scope-in-cypress
…alent-frontend-test-scope-in-cypress
…alent-frontend-test-scope-in-cypress # Conflicts: # tests/Frontend/e2e/GeneralApplication.cy.js # tests/Frontend/e2e/Login.cy.js # tests/Frontend/e2e/RoomsIndex.cy.js # tests/Frontend/e2e/RoomsViewGeneral.cy.js # tests/Frontend/support/commands.js
…alent-frontend-test-scope-in-cypress # Conflicts: # tests/Frontend/e2e/GeneralApplication.cy.js # tests/Frontend/e2e/Login.cy.js # tests/Frontend/e2e/RoomsIndex.cy.js # tests/Frontend/e2e/RoomsViewGeneral.cy.js # tests/Frontend/support/commands.js
…alent-frontend-test-scope-in-cypress
…alent-frontend-test-scope-in-cypress
…alent-frontend-test-scope-in-cypress
…alent-frontend-test-scope-in-cypress
…alent-frontend-test-scope-in-cypress # Conflicts: # CHANGELOG.md
…alent-frontend-test-scope-in-cypress # Conflicts: # .github/workflows/ci.yml
…alent-frontend-test-scope-in-cypress
…alent-frontend-test-scope-in-cypress # Conflicts: # package-lock.json # package.json
…alent-frontend-test-scope-in-cypress
…alent-frontend-test-scope-in-cypress # Conflicts: # CHANGELOG.md
…alent-frontend-test-scope-in-cypress # Conflicts: # CHANGELOG.md # resources/js/components/LocaleSelect.vue # resources/js/components/RoleSelect.vue # resources/js/components/RoomTabMembersAddSingleModal.vue # resources/js/components/RoomTabMembersBulkEditButton.vue # resources/js/components/RoomTabMembersBulkImportList.vue # resources/js/components/RoomTabMembersBulkImportModal.vue # resources/js/components/RoomTabMembersEditButton.vue # resources/js/components/RoomTransferOwnershipButton.vue # resources/js/components/UserTabProfile.vue # resources/js/components/UserTabSecurityRolesAndPermissionsSection.vue # resources/js/i18n.js
SamuelWei
approved these changes
Oct 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Great work!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1483 +/- ##
==============================================
- Coverage 95.35% 76.05% -19.30%
Complexity 1321 1321
==============================================
Files 202 359 +157
Lines 4582 8765 +4183
Branches 0 670 +670
==============================================
+ Hits 4369 6666 +2297
- Misses 213 2099 +1886 ☔ View full report in Codecov by Sentry. |
PILOS Run #862
Run Properties:
|
Project |
PILOS
|
Run status |
Passed #862
|
Run duration | 03m 44s |
Commit |
d41238fdbb: Reimplement frontend tests with cypress (#1483)
|
Committer | Sabrina Wüst |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
165
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially implements #1150
Implements #721
Implements #722
Type (Highlight the corresponding type)
Checklist
Changes