Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement OIDC #1205

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Conversation

pizkaz
Copy link
Contributor

@pizkaz pizkaz commented Jul 15, 2024

Fixes #300

Type (Highlight the corresponding type)

  • Bugfix
  • Feature
  • Documentation
  • Refactoring (e.g. Style updates, Test implementation, etc.)
  • Other (please describe):

Checklist

  • Code updated to current develop branch head
  • Passes CI checks
  • Is a part of an issue
  • Tests added for the bugfix or newly implemented feature, describe below why if not
  • Changelog is updated
  • Documentation of code and features exists

Changes

  • Implements OIDC authentication via OpenID-Connect-PHP

Other information

@pizkaz pizkaz force-pushed the 300-implement-oidc branch from 116b484 to cfa39ee Compare July 15, 2024 13:44
Copy link
Collaborator

@SamuelWei SamuelWei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few things noticed during a quick look

.env.example Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
resources/js/components/Login/ExternalLoginComponent.vue Outdated Show resolved Hide resolved
resources/js/router.js Outdated Show resolved Hide resolved
@SamuelWei SamuelWei added this to the v4.1 milestone Jul 17, 2024
@pizkaz pizkaz force-pushed the 300-implement-oidc branch from cfa39ee to 9d8a961 Compare July 17, 2024 13:38
config/auth.php Outdated Show resolved Hide resolved
@pizkaz pizkaz force-pushed the 300-implement-oidc branch from 9d8a961 to 499eea4 Compare July 18, 2024 09:48
Copy link

codecov bot commented Jul 18, 2024

Codecov Report

Attention: Patch coverage is 9.00000% with 91 lines in your changes missing coverage. Please review.

Project coverage is 80.15%. Comparing base (bf9cbb6) to head (a65f170).

Files with missing lines Patch % Lines
app/Auth/OIDC/OIDCController.php 0.00% 58 Missing ⚠️
app/Auth/OIDC/OpenIDConnectClient.php 0.00% 16 Missing ⚠️
app/Auth/OIDC/OIDCUser.php 0.00% 9 Missing ⚠️
resources/js/views/Login.vue 28.57% 5 Missing ⚠️
...p/Http/Controllers/api/v1/auth/LoginController.php 57.14% 3 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #1205      +/-   ##
=============================================
+ Coverage      77.21%   80.15%   +2.94%     
- Complexity      1333     1364      +31     
=============================================
  Files            359      362       +3     
  Lines           9189     9288      +99     
  Branches         845      849       +4     
=============================================
+ Hits            7095     7445     +350     
+ Misses          2094     1843     -251     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SamuelWei
Copy link
Collaborator

Should be build from scratch using https://github.com/jumbojett/OpenID-Connect-PHP, as this implementation is missing most security checks

@pizkaz pizkaz force-pushed the 300-implement-oidc branch 11 times, most recently from 863a94c to 4c06ec6 Compare July 25, 2024 13:52
@pizkaz pizkaz marked this pull request as ready for review July 25, 2024 13:54
@pizkaz pizkaz requested a review from SamuelWei July 25, 2024 13:55
@pizkaz pizkaz force-pushed the 300-implement-oidc branch from 4c06ec6 to c2256b4 Compare July 25, 2024 13:56
@pizkaz pizkaz force-pushed the 300-implement-oidc branch from c2256b4 to b3b9b92 Compare August 6, 2024 13:02
@pizkaz
Copy link
Contributor Author

pizkaz commented Aug 16, 2024

Hmm how can I convice GitHub that the requested changes were indeed addressed? 🧐

@pizkaz pizkaz force-pushed the 300-implement-oidc branch from b3b9b92 to 3bde8c3 Compare August 28, 2024 11:09
@pizkaz pizkaz force-pushed the 300-implement-oidc branch 3 times, most recently from 2c15c17 to 65e0749 Compare August 30, 2024 13:32
@SamuelWei SamuelWei modified the milestones: v4.1, v4.2 Sep 27, 2024
@pizkaz pizkaz force-pushed the 300-implement-oidc branch from 96e8409 to f4ad351 Compare October 16, 2024 11:23
@pizkaz pizkaz force-pushed the 300-implement-oidc branch from 173887c to 8104fba Compare November 4, 2024 15:13
Copy link

cypress bot commented Nov 18, 2024

PILOS    Run #1092

Run Properties:  status check passed Passed #1092  •  git commit 6ffffd17d5: 4.1 Release
Project PILOS
Branch Review 4.x
Run status status check passed Passed #1092
Run duration 03m 51s
Commit git commit 6ffffd17d5: 4.1 Release
Committer Samuel Weirich
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 177
View all changes introduced in this branch ↗︎

@pizkaz pizkaz force-pushed the 300-implement-oidc branch 2 times, most recently from f77093f to f7cc91d Compare November 21, 2024 17:41
@SamuelWei SamuelWei modified the milestones: v4.2, v4.3 Nov 25, 2024
@pizkaz pizkaz force-pushed the 300-implement-oidc branch from f7cc91d to a65f170 Compare November 26, 2024 12:08
@pizkaz
Copy link
Contributor Author

pizkaz commented Dec 13, 2024

OIDC conformance testing:

@SamuelWei SamuelWei modified the milestones: v4.3, v4.4 Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement OIDC as an alternative to LDAP
2 participants