-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement OIDC #1205
base: develop
Are you sure you want to change the base?
Implement OIDC #1205
Conversation
116b484
to
cfa39ee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few things noticed during a quick look
cfa39ee
to
9d8a961
Compare
9d8a961
to
499eea4
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1205 +/- ##
=============================================
+ Coverage 77.21% 80.15% +2.94%
- Complexity 1333 1364 +31
=============================================
Files 359 362 +3
Lines 9189 9288 +99
Branches 845 849 +4
=============================================
+ Hits 7095 7445 +350
+ Misses 2094 1843 -251 ☔ View full report in Codecov by Sentry. |
Should be build from scratch using https://github.com/jumbojett/OpenID-Connect-PHP, as this implementation is missing most security checks |
863a94c
to
4c06ec6
Compare
4c06ec6
to
c2256b4
Compare
c2256b4
to
b3b9b92
Compare
Hmm how can I convice GitHub that the requested changes were indeed addressed? 🧐 |
b3b9b92
to
3bde8c3
Compare
2c15c17
to
65e0749
Compare
65e0749
to
96e8409
Compare
96e8409
to
f4ad351
Compare
f4ad351
to
58436c2
Compare
173887c
to
8104fba
Compare
PILOS Run #1092
Run Properties:
|
Project |
PILOS
|
Branch Review |
4.x
|
Run status |
Passed #1092
|
Run duration | 03m 51s |
Commit |
6ffffd17d5: 4.1 Release
|
Committer | Samuel Weirich |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
177
|
View all changes introduced in this branch ↗︎ |
f77093f
to
f7cc91d
Compare
f7cc91d
to
a65f170
Compare
OIDC conformance testing:
|
Fixes #300
Type (Highlight the corresponding type)
Checklist
Changes
Other information