Fix crash in header parsing when trace count is parsing block_size
+ 1
#477
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There was an edge case when the trace count was 1 more than the N*block_size for parsing the grid headers; this caused a singleton array to return.
E.g. if the block size is 100 and we have 201 traces, blocks:
In the third block, this caused unexpected indexing and subsequent concatenation errors due to us manipulating a singleton array with slicing semantics.
Solution
Ensure the new filtered array is at least 1d by using
ndmin=1
in array constructor.