Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Copied MDIO Has Fill Value of Zero #190

Merged
merged 2 commits into from
Mar 4, 2023

Conversation

tasansal
Copy link
Collaborator

@tasansal tasansal commented Mar 4, 2023

It was defaulting to NaN for some reason.

@tasansal tasansal added the bug Something isn't working label Mar 4, 2023
@tasansal tasansal marked this pull request as ready for review March 4, 2023 13:58
@codecov-commenter
Copy link

codecov-commenter commented Mar 4, 2023

Codecov Report

Merging #190 (3ef90e8) into main (af5995e) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main     #190   +/-   ##
=======================================
  Coverage   80.60%   80.60%           
=======================================
  Files          43       43           
  Lines        1676     1676           
  Branches      189      189           
=======================================
  Hits         1351     1351           
  Misses        285      285           
  Partials       40       40           
Impacted Files Coverage Δ
src/mdio/api/convenience.py 28.57% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tasansal tasansal merged commit 0e2d732 into main Mar 4, 2023
@tasansal tasansal deleted the Ensure-copied-MDIO-has-fill-value-of-zero branch March 4, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants