feat: change input of name TNS register #978
Conversation
✅ Deploy Preview for testitori ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for teritori-dapp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
You don't create a specific component, you just copy what they done in CreateDAOSection.tsx but it's better to have an input component that check available names, that call the TextInputCustom etc. and called this component in CreateDAOSection and TNSNameFinderModal
There was a problem hiding this comment.
you mean use TextInputCustom in both file (CreateDAOSection and TNSNameFinderModal)?
and write logic in TextInputCustom ?
There was a problem hiding this comment.
Nope, create a specific input components in packages/components/inputs that called TextInputCustom and write logic in it. And after that call this specific component in CreateDAOSection and TNSNameFinderModal
VishalRakholiya-iView
force-pushed
the
tns-choosing-name-UI
branch
from
7a79ccb to
e5f7bd4
Compare
| const selectedWallet = useSelectedWallet(); | ||
| const [network] = parseUserId(selectedWallet?.userId); | ||
| const networkId = network?.id; | ||
| const cosmosNetwork = getCosmosNetwork(networkId); | ||
| const normalizedTokenId = ( | ||
| name + cosmosNetwork?.nameServiceTLD || "" | ||
| ).toLowerCase(); | ||
|
|
||
| const tokenId = name + cosmosNetwork?.nameServiceTLD || ""; | ||
|
|
||
| const { nsMintPrice: price } = useNSMintPrice(networkId, normalizedTokenId); | ||
| const { nameAvailable, loading } = useNSMintAvailability(networkId, tokenId); |
There was a problem hiding this comment.
all this should be inside the AvailableNamesInput component
There was a problem hiding this comment.
Yep you have to move the logic too in the component, if it's possible, but i think it is
| const selectedWallet = useSelectedWallet(); | ||
| const [network] = parseUserId(selectedWallet?.userId); | ||
| const networkId = network?.id; | ||
| const cosmosNetwork = getCosmosNetwork(networkId); | ||
| const normalizedTokenId = ( | ||
| name + cosmosNetwork?.nameServiceTLD || "" | ||
| ).toLowerCase(); | ||
|
|
||
| const tokenId = name + cosmosNetwork?.nameServiceTLD || ""; | ||
|
|
||
| const { nsMintPrice: price } = useNSMintPrice(networkId, normalizedTokenId); | ||
| const { nameAvailable, loading } = useNSMintAvailability(networkId, tokenId); |
There was a problem hiding this comment.
Yep you have to move the logic too in the component, if it's possible, but i think it is
VishalRakholiya-iView
force-pushed
the
tns-choosing-name-UI
branch
from
3fa18cc to
f96d3a1
Compare
| import { | ||
| neutral33, | ||
| neutral77, | ||
| primaryColor, | ||
| redDefault, | ||
| // primaryColor, |
There was a problem hiding this comment.
Just remove this comments
|
And please pass the CI, don't export |
|
The only thing i noticed in the UI is the equivalent in Please add the equivalent in dollars in the custom component you created 👍 |
No description provided.