Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: POC for Starknet #1490

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

feat: POC for Starknet #1490

wants to merge 17 commits into from

Conversation

hthieu1110
Copy link
Collaborator

@hthieu1110 hthieu1110 commented Jan 9, 2025

  • setup Starknet structure
  • add makefile build/test scripts
  • deploy test contract
  • integrate Starknet SDK with teritori
  • integrate ArgentX wallet with teritori
  • Implement todo-list contract: add_todo, get_todos, set_todo_done
  • Add tests for todo-list contract
  • Generate ABI + client SDK for todo-list contract
  • make some call to get contract data
  • make some transaction to contract
  • gen client SDK with typechain => we can use starknet-react for now, it already has a typed client

Copy link

netlify bot commented Jan 9, 2025

Deploy Preview for teritori-dapp ready!

Name Link
🔨 Latest commit 14d0985
🔍 Latest deploy log https://app.netlify.com/sites/teritori-dapp/deploys/67876965b390190008fece89
😎 Deploy Preview https://deploy-preview-1490--teritori-dapp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 9, 2025

Deploy Preview for gno-dapp ready!

Name Link
🔨 Latest commit 14d0985
🔍 Latest deploy log https://app.netlify.com/sites/gno-dapp/deploys/6787696532be8d000856c00e
😎 Deploy Preview https://deploy-preview-1490--gno-dapp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hthieu1110 hthieu1110 changed the title POC for Starknet feat: POC for Starknet Jan 15, 2025
@hthieu1110 hthieu1110 marked this pull request as ready for review January 15, 2025 07:36
Copy link
Collaborator

@clegirar clegirar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can only review front part, but sounds good for me.
Just a question, can we make this page accessible only in developerMode for the moment ? Does it make sense ?

@hthieu1110
Copy link
Collaborator Author

I can only review front part, but sounds good for me.

Just a question, can we make this page accessible only in developerMode for the moment ? Does it make sense ?

IMHO, it's not critical because this path is not accessible from any UI link so a user random cannot go there by mistake :D and in fact there is no really secret there, just my opinion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants