Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: font weight in music feed screen #1459

Merged
merged 3 commits into from
Dec 18, 2024
Merged

fix: font weight in music feed screen #1459

merged 3 commits into from
Dec 18, 2024

Conversation

clegirar
Copy link
Collaborator

@clegirar clegirar commented Dec 17, 2024 •
edited
Loading

Change the fontWeight in music feed screen

Before:
Screenshot 2024-12-17 at 12 28 59

After:
Screenshot 2024-12-17 at 12 29 09

@clegirar clegirar self-assigned this Dec 17, 2024
@netlify Netlify
Copy link

netlify bot commented Dec 17, 2024 •
edited
Loading

✅ Deploy Preview for gno-dapp ready!

Name Link
🔨 Latest commit aebdffb
🔍 Latest deploy log https://app.netlify.com/sites/gno-dapp/deploys/6761a74fa7afbf000877b1d5
😎 Deploy Preview https://deploy-preview-1459--gno-dapp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Dec 17, 2024 •
edited
Loading

✅ Deploy Preview for teritori-dapp ready!

Name Link
🔨 Latest commit aebdffb
🔍 Latest deploy log https://app.netlify.com/sites/teritori-dapp/deploys/6761a74f89a693000822e0dc
😎 Deploy Preview https://deploy-preview-1459--teritori-dapp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

n0izn0iz
n0izn0iz requested changes Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@n0izn0iz n0izn0iz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the modal title change completely break some modals, for example this is what I get if I click "publish as artist" without a wallet connected:
Screenshot 2024-12-17 at 16 38 26

@clegirar clegirar changed the title fix: font weight in music feed screen & header modal base align fix: font weight in music feed screen Dec 17, 2024
@n0izn0iz n0izn0iz changed the title fix: font weight in music feed screen fix: font weight in music feed screen and modals titles Dec 17, 2024
n0izn0iz
n0izn0iz approved these changes Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@n0izn0iz n0izn0iz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@n0izn0iz n0izn0iz enabled auto-merge December 17, 2024 19:50
@clegirar clegirar changed the title fix: font weight in music feed screen and modals titles fix: font weight in music feed screen Dec 18, 2024
@n0izn0iz n0izn0iz added this pull request to the merge queue Dec 18, 2024
Merged via the queue into main with commit 88ca6f3 Dec 18, 2024
25 checks passed
@n0izn0iz n0izn0iz deleted the fix/font-weight-music-feed-screen branch December 18, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikaelVallenet MikaelVallenet MikaelVallenet approved these changes

@n0izn0iz n0izn0iz n0izn0iz approved these changes

Assignees

@clegirar clegirar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@clegirar @n0izn0iz @MikaelVallenet