Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Show the asterix in "regular" required TextInputCustom #1457

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

WaDadidou
Copy link
Collaborator

@WaDadidou WaDadidou commented Dec 17, 2024

Closes #1458
This PR adds a behavior present on TextInputCustom "labelOutside" but missing on "regular"
(The red asterix next to the label for required inputs)

Before

image

After

image


The "labelOutside" variant

image

@WaDadidou WaDadidou added enhancement New feature or request UX/UI labels Dec 17, 2024
Copy link

netlify bot commented Dec 17, 2024

Deploy Preview for gno-dapp ready!

Name Link
🔨 Latest commit 225249f
🔍 Latest deploy log https://app.netlify.com/sites/gno-dapp/deploys/6760cd4a736b1f00080439a0
😎 Deploy Preview https://deploy-preview-1457--gno-dapp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 17, 2024

Deploy Preview for teritori-dapp ready!

Name Link
🔨 Latest commit 225249f
🔍 Latest deploy log https://app.netlify.com/sites/teritori-dapp/deploys/6760cd4aa745cb0008207ff6
😎 Deploy Preview https://deploy-preview-1457--teritori-dapp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@hthieu1110 hthieu1110 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@n0izn0iz n0izn0iz changed the title fix: Show the asterix in "regular" required TestInputCustom fix: Show the asterix in "regular" required TextInputCustom Dec 17, 2024
Copy link
Collaborator

@n0izn0iz n0izn0iz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@n0izn0iz n0izn0iz enabled auto-merge December 17, 2024 06:24
@n0izn0iz n0izn0iz added this pull request to the merge queue Dec 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 17, 2024
@n0izn0iz n0izn0iz added this pull request to the merge queue Dec 17, 2024
Merged via the queue into main with commit c5afb2f Dec 17, 2024
25 checks passed
@n0izn0iz n0izn0iz deleted the fix-text-input-regular-asterix branch December 17, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request UX/UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Required input doesn't have the red asterix
4 participants