feat: allow to make article proposal #1456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for gno-dapp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for teritori-dapp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Norman Meier <[email protected]>
n0izn0iz
force-pushed
the
dao-article
branch
from
efd6c32 to
02c6629
Compare
Signed-off-by: Norman Meier <[email protected]>
MikaelVallenet
previously approved these changes
Dec 16, 2024
WaDadidou
approved these changes
Dec 16, 2024
There was a problem hiding this comment.
It's LGTM for me, except for one issue (fixed here: 91d4779)
The issue:
If I choose a DAO wallet from our screen, then I select another wallet from Keplr, DAOSelector is not resetted, so it keep the selected DAO wallet, and "Propose" in the button
This state bellow must be impossible:
MikaelVallenet
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you have a wallet connected that is member of DAOs, you can select a DAO to post with