Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show correct logo on mobile + space around mobile search button #1445

Merged
merged 5 commits into from
Dec 6, 2024

Conversation

n0izn0iz
Copy link
Collaborator

@n0izn0iz n0izn0iz commented Dec 5, 2024

  • rework TopLogo component to be responsive
  • remove TopLogoMobile component
  • use TopLogo instead of TopLogoMobile in MobileHeader
  • add space after search button on mobile
  • add shortcut to script to switch app, you can now run yarn switch-app <app-name>

Before (Gnotribe):
Screenshot 2024-12-05 at 14 38 44
After:
Screenshot 2024-12-05 at 14 37 50

Copy link

netlify bot commented Dec 5, 2024

Deploy Preview for teritori-dapp ready!

Name Link
🔨 Latest commit 645891f
🔍 Latest deploy log https://app.netlify.com/sites/teritori-dapp/deploys/6752af4b7776df00086f3763
😎 Deploy Preview https://deploy-preview-1445--teritori-dapp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 5, 2024

Deploy Preview for gno-dapp ready!

Name Link
🔨 Latest commit 645891f
🔍 Latest deploy log https://app.netlify.com/sites/gno-dapp/deploys/6752af4be6f8ff00089bea27
😎 Deploy Preview https://deploy-preview-1445--gno-dapp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@n0izn0iz n0izn0iz changed the title fix: show correct logo on mobile fix: show correct logo on mobile + space around mobile search button Dec 5, 2024
Copy link
Collaborator

@clegirar clegirar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested 👍

@n0izn0iz n0izn0iz enabled auto-merge December 5, 2024 18:36
@n0izn0iz n0izn0iz disabled auto-merge December 6, 2024 08:16
@n0izn0iz
Copy link
Collaborator Author

n0izn0iz commented Dec 6, 2024

aussi, en vertu de l'article 49 alinéa 3 de la constitution, j'engage la responsabilité de mon organisation décentralisée sur l'application de la requête de fusionnement numéro 1445

@n0izn0iz n0izn0iz merged commit dd33718 into main Dec 6, 2024
23 checks passed
@n0izn0iz n0izn0iz deleted the mobile-logo branch December 6, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants