-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add permissions & voting power per roles per features #1443
feat: add permissions & voting power per roles per features #1443
Conversation
…ori-dapp into e2e-test-dao-creation-gno
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Partial
packages/screens/Organizations/components/RolesOrg/RolesSettingsSection.tsx
Outdated
Show resolved
Hide resolved
<View style={{ flex: 1, flexDirection: "row" }}> | ||
<TouchableOpacity onPress={() => onCheckboxChange(index)}> | ||
<CheckboxDappStore isChecked={resource.value} /> | ||
</TouchableOpacity> | ||
<SpacerRow size={1} /> | ||
<BrandText style={fontSemibold18}>{resource.name}</BrandText> | ||
<SpacerColumn size={4} /> | ||
</View> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can import Checkbox from "@/screens/Mini/components/Checkbox/Checkbox";
(Btw, yes, we must export that from Mini
, it makes non sense)
<View style={{ flex: 1, flexDirection: "row" }}> | |
<TouchableOpacity onPress={() => onCheckboxChange(index)}> | |
<CheckboxDappStore isChecked={resource.value} /> | |
</TouchableOpacity> | |
<SpacerRow size={1} /> | |
<BrandText style={fontSemibold18}>{resource.name}</BrandText> | |
<SpacerColumn size={4} /> | |
</View> | |
<> | |
<SpacerColumn size={.5} /> | |
<Checkbox | |
isChecked={resource.value} | |
value={resource.name} | |
label={resource.name} | |
onPress={() => onCheckboxChange(index)} | |
/> | |
<SpacerColumn size={.5} /> | |
</> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think i tried the mini but it was smaller and looked weird but i will see
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we open an hackmd for next priorities ? I have some suggestions too (pure UI for the moment) |
Yes sure i will open this ASAP |
// important to keep this order since voting module might depend on roles module | ||
core.rolesModule = rolesModuleFactory(core) | ||
if core.rolesModule == nil { | ||
panic("roles module factory returned nil") | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should remove the role manager from the core interfaces and implem, is there a real need to have it there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to inform ppl, we decided to do this improvement in a next PR
aussi, sur le fondement de l'article 49 alinéa 3 de la constitution, j'engage la responsabilité de mon organisation décentralisée sur l'application de la requête de fusionnement numéro 1443 |
Add permissions & voting power per roles per resources
PR Description
Hello, This PR have for goal to allow people to assign resources to roles they create for their DAOs
I do this through a modal where user can check what resource they want for the role they are creating
Then when a user with the roles votes it looks like this for now (For now user can just assign 999 voting power to roles, but we have to think of a way to handle this as a user input when creating the roles)
It would be nice to have a way to display this in a more intuitive / explicite way, need to be discussed
What have be done
DoD checklist...
IVotingModule
to accept a feature when retrieving voting powerRolesVotingModule
{resource, power}
What Next Priotities:
Add a user input to set the power of a role (numeric) - assign to me @MikaelVallenet
Change the Roles Settings Page in the creation form flow
I would like a table to see the roles with a details modal with all roles when we click on it
Dropdown to allow to assign user with roles created
Use a select input in
RolesSettingsSection
, plugged to the previously created rolesAdd a Roles Page that display each roles settings based on UI of an IAM/excel table
Use the color choose to display the roles
Change the text input by a dropdown multi selector
What could be nice to have
Color Picker to choose the role color
Create a color picker and use it in
MultisigMembers
Enhance Roles Review
Display resources linked to roles in a better way