-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(orgs): split creation flows + add new kind of roles based organization #1429
feat(orgs): split creation flows + add new kind of roles based organization #1429
Conversation
…ori-dapp into e2e-test-dao-creation-gno
packages/screens/Organizations/components/MembershipOrg/MembershipMemberSettingsSection.tsx
Show resolved
Hide resolved
…mbership based dao
@@ -37,3 +37,17 @@ type IProposalModule interface { | |||
} | |||
|
|||
type ProposalModuleFactory func(core IDAOCore) IProposalModule | |||
|
|||
type IRolesModule interface { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO, it could be nice and more practice if we handle AddressOrName instead of only Address
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I disagree, if we do we have to add a way to resolve users by passing a resolver in the role module, increasing gas cost, dependencies and complexity
then if at some point usernames can change, we get a lot of headache
IMO it's better to always operate on addresses where possible
Integration of Roles Manager into Organizations Flow
The roles manager allow to manage roles & permissions on a user base.
This PR integrates it into our DAO gno contracts
Exhaustive list of additions:
RolesModule
within DAO Core with its own interface seegno/p/dao_interfaces
dao_roles_group
that implements the interfaceIRolesModule
IsRoleExist
,CountRoles
,GetUserRoles(user)
intorole manager
pure pkggetDuration
&&getPercent
intoutils/gnodao/helpers.ts
organizations/**