fix: dao proposals query key #1412
Conversation
Signed-off-by: Norman Meier <[email protected]>
✅ Deploy Preview for teritori-dapp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for testitori ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
as the name of the hook is useDAOProposals which is sth generic, not dedicated to Gno so I suggest:
- either keep the hook generic name and make all the query keys (string "gno" => networkId) more generic
- or change the name to useGnoDAOProposal
but not mix both generic name + hardcoded network => quite confusing
hthieu1110
dismissed
their stale review
change from Change requested => Comment
There was a problem hiding this comment.
as the name of the hook is useDAOProposals which is sth generic, not dedicated to Gno so I suggest:
either keep the hook generic name and make all the query keys (string "gno" => networkId) more generic
or change the name to useGnoDAOProposal
but not mix both generic name + hardcoded network => quite confusing
|
I think you misread the diff, the hook is indeed generic, it's just that the gno version is not extracted where the cosmwasm one is It was a quickfix but I can refacto to improve clarity |
|
merging because this bug is very anoying |
without this, if we query the proposals for a teritori dao and the gno query resolves first with nothing, the teritori query will return an empty list